Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Guarantees Support #39

Merged
merged 3 commits into from
Mar 5, 2019
Merged

Add Guarantees Support #39

merged 3 commits into from
Mar 5, 2019

Conversation

djtech42
Copy link
Contributor

allow await(guarantee)
(currently guarantees do not work here as they are not Promises)

@codecov
Copy link

codecov bot commented Feb 25, 2019

Codecov Report

Merging #39 into master will decrease coverage by 2.56%.
The diff coverage is 60%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #39      +/-   ##
==========================================
- Coverage   69.23%   66.66%   -2.57%     
==========================================
  Files           4        4              
  Lines          26       36      +10     
==========================================
+ Hits           18       24       +6     
- Misses          8       12       +4
Impacted Files Coverage Δ
Sources/AwaitKit/AwaitKit.swift 0% <0%> (ø) ⬆️
Sources/AwaitKit/DispatchQueue+Await.swift 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce4fc4f...b40d335. Read the comment docs.

@codecov
Copy link

codecov bot commented Feb 25, 2019

Codecov Report

Merging #39 into master will increase coverage by 1.35%.
The diff coverage is 75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #39      +/-   ##
==========================================
+ Coverage   69.23%   70.58%   +1.35%     
==========================================
  Files           4        4              
  Lines          26       34       +8     
==========================================
+ Hits           18       24       +6     
- Misses          8       10       +2
Impacted Files Coverage Δ
Sources/AwaitKit/AwaitKit.swift 0% <0%> (ø) ⬆️
Sources/AwaitKit/DispatchQueue+Await.swift 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce4fc4f...83cd3f4. Read the comment docs.

@yannickl yannickl merged commit ff456f4 into yannickl:master Mar 5, 2019
@yannickl
Copy link
Owner

yannickl commented Mar 5, 2019

Thank you very much for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants