-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Carthage support #18
Carthage support #18
Conversation
…module. Updated the Travis CI config. Bumped the podspec version. Upgraded the dependency to the latest version. Created a Xcode project just for the framework because Carthage needs it. Created a single framework target and a single framework tests target for all the supported platforms just like PromiseKit is doing. Updated the Example project and it's Podfile.
…hen using the whole-module optimization.
…d to run from Xcode.
Codecov Report
@@ Coverage Diff @@
## master #18 +/- ##
==========================================
- Coverage 100% 99.43% -0.57%
==========================================
Files 4 7 +3
Lines 49 176 +127
==========================================
+ Hits 49 175 +126
- Misses 0 1 +1
Continue to review full report at Codecov.
|
Oh nice! That's a really great work. Thank you very much! |
Thanks! 😀 |
I forgot to mention that you need to push a new tag, maybe "3.0.2" or "3.1.0" if you want to fully support Carthage. By default if you specify |
Changes
.gitignore
file.PromiseKit
dependency as a submodule.Example
project and it'sPodfile
.README.md
file to reflect the Carthage support.