Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Carthage support #18

Merged
merged 7 commits into from
Aug 18, 2017
Merged

Carthage support #18

merged 7 commits into from
Aug 18, 2017

Conversation

arturgrigor
Copy link
Contributor

Changes

  • Updated the .gitignore file.
  • Added the PromiseKit dependency as a submodule.
  • Updated the Travis CI config.
  • Bumped the podspec version.
  • Upgraded the dependency to the latest version.
  • Created an Xcode project just for the framework because Carthage needs it.
  • Created a single framework target and a single framework tests target for all the supported platforms just like PromiseKit has.
  • Updated the Example project and it's Podfile.
  • Updated the README.md file to reflect the Carthage support.

…module. Updated the Travis CI config. Bumped the podspec version. Upgraded the dependency to the latest version. Created a Xcode project just for the framework because Carthage needs it. Created a single framework target and a single framework tests target for all the supported platforms just like PromiseKit is doing. Updated the Example project and it's Podfile.
@codecov-io
Copy link

Codecov Report

Merging #18 into master will decrease coverage by 0.56%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #18      +/-   ##
==========================================
- Coverage     100%   99.43%   -0.57%     
==========================================
  Files           4        7       +3     
  Lines          49      176     +127     
==========================================
+ Hits           49      175     +126     
- Misses          0        1       +1
Impacted Files Coverage Δ
Tests/AwaitKitAsyncTests.swift 100% <ø> (ø)
Tests/AwaitKitAwaitTests.swift 98.21% <ø> (ø)
Tests/AwaitKitTests.swift 100% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7416485...1388ff6. Read the comment docs.

@yannickl
Copy link
Owner

Oh nice! That's a really great work. Thank you very much!

@yannickl yannickl merged commit b5d4494 into yannickl:master Aug 18, 2017
@arturgrigor
Copy link
Contributor Author

Thanks! 😀

@arturgrigor
Copy link
Contributor Author

I forgot to mention that you need to push a new tag, maybe "3.0.2" or "3.1.0" if you want to fully support Carthage.

By default if you specify github "yannickl/AwaitKit" in your Cartfile Carthage will download the latest released version and right now the version 3.0.1 doesn't have Carthage support and that's why a new tag is needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants