Skip to content

Fix weekly test-windows/test-macos action #413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
yamcodes wants to merge 1 commit into from
Closed

Fix weekly test-windows/test-macos action #413

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
56 changes: 24 additions & 32 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,34 +126,30 @@ jobs:
retention-days: 30
test-windows:
if: github.event_name == 'schedule' || contains(join(github.event.pull_request.labels.*.name, ','), 'windows')
runs-on: windows-latest
needs: resolve-playwright-version
runs-on: ubuntu-latest
strategy:
Comment on lines 128 to 131
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot Nov 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Windows/macOS jobs no longer exercise target OSes

The test-windows job now declares runs-on: ubuntu-latest and runs inside the Playwright Linux container (same pattern at lines 164‑167 for test-macos), so even when the windows/macos labels are applied or on the scheduled run, we only exercise Linux. That removes the Windows and macOS coverage this workflow used to provide (there are no other runs-on: windows/macos jobs in the repo), so platform-specific regressions will slip through while the jobs still appear to have validated those platforms.

Useful? React with 👍 / 👎.

matrix:
node-version: [lts/*, latest]
continue-on-error: ${{ matrix.node-version == 'latest' }}
container:
image: mcr.microsoft.com/playwright:v${{ needs.resolve-playwright-version.outputs.version }}-noble
options: --user 1001
steps:
- uses: actions/checkout@v5
with:
fetch-depth: 2 # for checking against main and for following the PR history

- name: Install pnpm
uses: pnpm/action-setup@v4

- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v6
- name: Set Turbo base/head for PRs
if: ${{ github.event_name == 'pull_request' }}
run: |
echo "TURBO_SCM_BASE=${{ github.event.pull_request.base.sha || github.event.before }}" >> $GITHUB_ENV
echo "TURBO_SCM_HEAD=${{ github.sha }}" >> $GITHUB_ENV
- uses: pnpm/action-setup@v4
- uses: actions/setup-node@v6
with:
node-version: ${{ matrix.node-version }}
cache: pnpm
- run: pnpm install
- uses: actions/cache@v4
with:
path: ~/.cache/ms-playwright
key: windows-latest-pw-${{ hashFiles('pnpm-lock.yaml') }}-${{ matrix.node-version }}
restore-keys: |
windows-latest-pw-${{ hashFiles('pnpm-lock.yaml') }}-
windows-latest-pw-
- name: Install Playwright browsers
run: pnpm exec playwright install --with-deps
- run: pnpm build
- run: pnpm run test
- run: pnpm run test:e2e
Expand All @@ -166,34 +162,30 @@ jobs:

test-macos:
if: github.event_name == 'schedule' || contains(join(github.event.pull_request.labels.*.name, ','), 'macos')
runs-on: macos-latest
needs: resolve-playwright-version
runs-on: ubuntu-latest
strategy:
matrix:
node-version: [lts/*, latest]
continue-on-error: ${{ matrix.node-version == 'latest' }}
container:
image: mcr.microsoft.com/playwright:v${{ needs.resolve-playwright-version.outputs.version }}-noble
options: --user 1001
steps:
- uses: actions/checkout@v5
with:
fetch-depth: 2 # for checking against main and for following the PR history

- name: Install pnpm
uses: pnpm/action-setup@v4

- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v6
- name: Set Turbo base/head for PRs
if: ${{ github.event_name == 'pull_request' }}
run: |
echo "TURBO_SCM_BASE=${{ github.event.pull_request.base.sha || github.event.before }}" >> $GITHUB_ENV
echo "TURBO_SCM_HEAD=${{ github.sha }}" >> $GITHUB_ENV
- uses: pnpm/action-setup@v4
- uses: actions/setup-node@v6
with:
node-version: ${{ matrix.node-version }}
cache: pnpm
- run: pnpm install
- uses: actions/cache@v4
with:
path: ~/.cache/ms-playwright
key: macos-latest-pw-${{ hashFiles('pnpm-lock.yaml') }}-${{ matrix.node-version }}
restore-keys: |
macos-latest-pw-${{ hashFiles('pnpm-lock.yaml') }}-
macos-latest-pw-
- name: Install Playwright browsers
run: pnpm exec playwright install --with-deps
- run: pnpm build
- run: pnpm run test
- run: pnpm run test:e2e
Expand Down
Loading