You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The issue happened because the size task was defined in the root turbo.json with "dependsOn": ["build"]. In Turborepo, defining a task at the root automatically registers it for all workspaces, even if only one package actually has that script. Since size depended on build, every package pulled its own build task into the graph. The fix was to move the size task definition into packages/arkenv/turbo.json so it only exists in that package. Now, when running turbo run size, only ArkEnv builds and runs its size check.
Summary by CodeRabbit
Chores
Integrated package size validation tooling with automated size checking into the build system
Configured a 2 kB size limit for the vite-plugin package
Established dedicated size-checking tasks at the individual package level with appropriate build task dependencies
Updated root-level build task configuration to support decentralized package-level task management
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
This PR adds size-limit bundle tracking to the @arkenv/vite-plugin package and restructures the Turbo task configuration. A "size" task is removed from the root turbo.json and defined at the package level for both arkenv and vite-plugin via new turbo.json files. The vite-plugin package gains size-limit dependencies, a size script, and a 2 kB configuration constraint.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@arkenv/vite-pluginIssues or Pull Requests involving the Vite plugin for ArkEnvarkenvChanges to the `arkenv` npm package.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #351
Closes #323
The issue happened because the size task was defined in the root
turbo.jsonwith"dependsOn": ["build"]. In Turborepo, defining a task at the root automatically registers it for all workspaces, even if only one package actually has that script. Since size depended on build, every package pulled its own build task into the graph. The fix was to move the size task definition intopackages/arkenv/turbo.jsonso it only exists in that package. Now, when running turbo run size, only ArkEnv builds and runs its size check.Summary by CodeRabbit