Skip to content

chore: improve clean script with turbo#337

Merged
yamcodes merged 3 commits intomainfrom
331-pnpm-run-clean-from-the-root-should-clean-all-packages
Nov 10, 2025
Merged

chore: improve clean script with turbo#337
yamcodes merged 3 commits intomainfrom
331-pnpm-run-clean-from-the-root-should-clean-all-packages

Conversation

@yamcodes
Copy link
Owner

@yamcodes yamcodes commented Nov 10, 2025

  • Use turbo to run clean script
  • Define root clean script

Closes #331

Summary by CodeRabbit

  • Chores
    • Updated the cleanup workflow to run via the project task runner instead of invoking cleanup directly.
    • Added a dedicated root cleanup task and configured it to skip caching and depend on existing clean steps.

- Use turbo to run clean script
- Define root clean script
@yamcodes yamcodes linked an issue Nov 10, 2025 that may be closed by this pull request
@changeset-bot
Copy link

changeset-bot bot commented Nov 10, 2025

⚠️ No Changeset found

Latest commit: 44186b9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Nov 10, 2025

Deployment failed with the following error:

Resource is limited - try again in 24 minutes (more than 100, code: "api-deployments-free-per-day").

Learn More: https://vercel.com/yamcodes?upgradeToPro=build-rate-limit

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 10, 2025

Warning

Rate limit exceeded

@yamcodes has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 27 minutes and 52 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between d268540 and 44186b9.

📒 Files selected for processing (8)
  • apps/playgrounds/bun-react/package.json (1 hunks)
  • apps/playgrounds/node/package.json (1 hunks)
  • apps/playgrounds/vite/package.json (1 hunks)
  • examples/basic/package.json (1 hunks)
  • examples/with-bun-react/package.json (1 hunks)
  • examples/with-bun/package.json (1 hunks)
  • examples/with-vite-react-ts/package.json (1 hunks)
  • tooling/playwright-www/package.json (1 hunks)

Note

Other AI code review bot(s) detected

CodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review.

Walkthrough

The PR changes the root cleanup to run via Turbo: the root clean script now invokes turbo run root:clean clean, and a new root:clean script/task was added to perform the original rimraf-based removal; Turbo task entry for root:clean (cache disabled, dependsOn ^clean) was added to turbo.json.

Changes

Cohort / File(s) Summary
Script delegation
package.json
clean changed from rimraf dist node_modules to turbo run root:clean clean. Added new root:clean script: rimraf dist node_modules.
Task configuration
turbo.json
Added task entry //#root:clean with { "cache": false, "dependsOn": ["^clean"] } to expose root-level cleanup to Turbo orchestration.

Sequence Diagram

sequenceDiagram
    actor User
    participant RootScript as Root `clean` script
    participant Turbo
    participant RootTask as `root:clean` task
    participant Packages as package `clean` tasks

    User->>RootScript: pnpm run clean
    RootScript->>Turbo: turbo run root:clean clean
    par Execute in parallel
        Turbo->>RootTask: run root:clean
        RootTask->>RootTask: rimraf dist node_modules
        Turbo->>Packages: run clean in all packages (dependsOn ^clean)
        Packages->>Packages: package-level cleanup (rimraf etc.)
    end
    Turbo-->>User: tasks complete
Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

  • Small, focused configuration changes.
  • Areas to check:
    • package.json script formatting and any CI/tooling assumptions about script names.
    • turbo.json key naming (comment-like key //#root:clean) and correctness of dependsOn semantics.

Suggested labels

arkenv

Poem

🐰 I hop and tidy, swift and keen,
Root clean now speaks through Turbo's machine,
Rimraf hums where branches once lay,
Packages sparkle, dirt held at bay,
A little rabbit cheers the clean routine.

Pre-merge checks and finishing touches

✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: introducing turbo to improve the clean script workflow.
Linked Issues check ✅ Passed The changes fully implement the linked issue #331 requirement: the root clean script now orchestrates both root cleanup and turbo run clean for all packages.
Out of Scope Changes check ✅ Passed All changes in package.json and turbo.json are directly related to implementing the turbo-based clean script as specified in issue #331.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3c1b045 and d6618db.

📒 Files selected for processing (2)
  • package.json (1 hunks)
  • turbo.json (1 hunks)
🔇 Additional comments (1)
turbo.json (1)

7-9: Root task definition looks good.

The //#root:clean task is properly configured as a root-level turbo task with caching appropriately disabled for cleanup operations. The naming convention is clear and follows established patterns.

- Ensure dependent tasks are cleaned
@vercel
Copy link

vercel bot commented Nov 10, 2025

Deployment failed with the following error:

Resource is limited - try again in 16 minutes (more than 100, code: "api-deployments-free-per-day").

Learn More: https://vercel.com/yamcodes?upgradeToPro=build-rate-limit

- Added `clean` script using `rimraf`
- Cleans `dist` and `node_modules` folders
@vercel
Copy link

vercel bot commented Nov 10, 2025

Deployment failed with the following error:

Resource is limited - try again in 14 minutes (more than 100, code: "api-deployments-free-per-day").

Learn More: https://vercel.com/yamcodes?upgradeToPro=build-rate-limit

@github-actions github-actions bot added the example Issues or Pull Requests concerning at least one ArkEnv example. (Found in the `examples/` directory) label Nov 10, 2025
@yamcodes yamcodes merged commit bcd9c0d into main Nov 10, 2025
13 of 14 checks passed
@yamcodes yamcodes deleted the 331-pnpm-run-clean-from-the-root-should-clean-all-packages branch November 10, 2025 15:45
@coderabbitai coderabbitai bot mentioned this pull request Dec 8, 2025
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

example Issues or Pull Requests concerning at least one ArkEnv example. (Found in the `examples/` directory)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"pnpm run clean" from the root should clean all packages

1 participant