Skip to content

refactor: simplify accessibility smoke tests by removing disabled rules #293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yamcodes merged 1 commit into from
Nov 8, 2025
Merged

refactor: simplify accessibility smoke tests by removing disabled rules #293

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 1 addition & 18 deletions tooling/playwright-www/tests/a11y.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,24 +155,7 @@ test.describe("A11y Smoke Tests", () => {
await page.waitForLoadState("networkidle");

// Page-level smoke test with rules disabled for known issues
await assertNoA11yViolations(page, {
disableRules: [
// Known issues from third-party libraries
// TODO: Re-enable once fumadocs-twoslash fixes aria-allowed-attr violation
// fumadocs-twoslash renders <span class="twoslash-hover" type="button"> which is invalid HTML
// Should use <button> element instead of <span> for interactive hover triggers
// Track: https://github.com/fuma-nama/fumadocs/issues/2574
"aria-allowed-attr", // shiki-twoslash
// TODO: Re-enable once fumadocs-ui fixes scrollable-region-focusable
// code block containers need keyboard focus
// Track: https://github.com/fuma-nama/fumadocs/issues/2573
"scrollable-region-focusable",
// TODO: Re-enable once fumadocs-ui fixes listitem issue
// fumadocs-ui renders secondary nav items in <div> instead of <ul>
// Track: https://github.com/fuma-nama/fumadocs/issues/2566
"listitem",
],
});
await assertNoA11yViolations(page);
}
});

Expand Down
Loading