Turborepo fixes (Best practices) by yamcodes · Pull Request #216 · yamcodes/arkenv

yamcodes · 2025-10-12T18:25:06Z

Removed brace-expansion and jsdom from devDependencies in package.json.
Updated pnpm-lock.yaml to reflect the removal of these dependencies and clean up unnecessary entries.
Adjusted CI workflow to use pnpm turbo run test instead of the deprecated pnpm test:ci command.
Streamlined test commands in package.json files across packages to enhance consistency.

Ref:

Summary by CodeRabbit

Tests
- Unified CI test execution to a single turbo-driven test task.
- Removed legacy test:ci scripts across packages.
Chores
- Added new type-check and error-check tasks to improve validation.
- Updated task dependencies and test task inputs; removed caching/persistence for more consistent runs.
- Removed some dev-only test-related dependencies and scripts.
Note
- No user-facing features or behavioral changes in this release.

…pendencies - Removed `brace-expansion` and `jsdom` from devDependencies in package.json. - Updated pnpm-lock.yaml to reflect the removal of these dependencies and clean up unnecessary entries. - Adjusted CI workflow to use `pnpm turbo run test` instead of the deprecated `pnpm test:ci` command. - Streamlined test commands in package.json files across packages to enhance consistency.

changeset-bot · 2025-10-12T18:25:10Z

⚠️ No Changeset found

Latest commit: 43ca656

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

vercel · 2025-10-12T18:25:12Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Preview	Comments	Updated (UTC)
arkenv	Ready	Preview	Comment	Oct 12, 2025 6:37pm

coderabbitai · 2025-10-12T18:25:15Z

Caution

Review failed

The pull request is closed.

Walkthrough

Replaces CI test invocation to use Turborepo (pnpm turbo run test), removes package-level test:ci scripts and two devDependencies, updates turbo.json tasks (removes test:ci, adds check tasks, modifies test and typecheck inputs/dependsOn), and removes several app-level test scripts.

Changes

Cohort / File(s)	Summary of edits
CI workflow `.github/workflows/tests.yml`	Changed test step command from `pnpm test:ci` to `pnpm turbo run test`.
Turborepo tasks `turbo.json`	Removed `test:ci`; added `//#check` and `check:errors`; `typecheck` now `dependsOn: ["transit"]`; `test` now depends on `transit`, removed `cache`/`persistent`, added `inputs` including `vitest.config.ts`.
Root package manifest `package.json`	Removed devDependencies `brace-expansion` and `jsdom`; replaced/adjusted CI test script names (`test:ci` → `test:ui` change present).
App scripts `apps/www/package.json`	Removed `test:ci`, `test:ui`, and `test:coverage` scripts.
Workspace package scripts `packages/arkenv/package.json`, `packages/vite-plugin/package.json`	Removed `test:ci` scripts (Vitest-run entries).

Sequence Diagram(s)

sequenceDiagram
  autonumber
  participant GH as GitHub Actions
  participant Turbo as Turborepo
  participant PKG as Workspace Packages
  rect rgba(0,128,96,0.06)
    GH->>Turbo: run `pnpm turbo run test`
    Note right of Turbo: `test` dependsOn: transit\ninputs include vitest.config.ts
    Turbo->>PKG: run `transit` tasks
    Turbo->>PKG: run package `test` tasks
  end
  alt tests pass
    PKG-->>Turbo: success
    Turbo-->>GH: workflow success
  else tests fail
    PKG-->>Turbo: failure
    Turbo-->>GH: workflow failure
  end

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

Leverage Turborepo for caching Vitest #213 — Modifies CI test commands, package test scripts, and turborepo test/task entries (strong overlap).
Integration tests #108 — Changes to Vitest configuration and test tooling that interact with updated Turbo inputs.

Suggested labels

tests

Poem

Thump-thump, I tweak the testy trail,
Hopped from ci to turbo’s rail.
Scripts trimmed neat, checks queued in line,
Transit first, then tests combine.
I nibble logs and hop away—green pass shine. 🥕

Pre-merge checks and finishing touches

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Title Check	❓ Inconclusive	The title “Turborepo fixes (Best practices)” is too generic to convey the specific changes made, such as updating CI workflows to use pnpm turbo run test and removing deprecated test scripts and dependencies. It references “fixes” and “best practices” without indicating the actual intent or affected area of the repository.	Consider rewriting the title to clearly reflect the core changes, such as updating CI workflows to use pnpm turbo run test and removing deprecated test scripts across packages. A more descriptive title might be “Use pnpm turbo run test in CI and remove deprecated test scripts” to immediately inform reviewers of the PR’s intent.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage	✅ Passed	No functions found in the changes. Docstring coverage check skipped.

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8c9b3e3 and 43ca656.

📒 Files selected for processing (1)

turbo.json (1 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

pkg-pr-new · 2025-10-12T18:26:51Z

Open in StackBlitz

npm i https://pkg.pr.new/arkenv@216

npm i https://pkg.pr.new/@arkenv/vite-plugin@216

commit: 43ca656

- Introduced a new `test:ui` command in the root package.json for running Vitest with a UI. - Removed `test:ci` and `test:coverage` commands from the www package.json to streamline test scripts and enhance consistency across packages.

coderabbitai

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a25d071 and 8c9b3e3.

⛔ Files ignored due to path filters (1)

pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml

📒 Files selected for processing (6)

.github/workflows/tests.yml (1 hunks)
apps/www/package.json (0 hunks)
package.json (1 hunks)
packages/arkenv/package.json (0 hunks)
packages/vite-plugin/package.json (0 hunks)
turbo.json (1 hunks)

💤 Files with no reviewable changes (3)

packages/vite-plugin/package.json
packages/arkenv/package.json
apps/www/package.json

turbo.json

- Included default and Vitest configuration file paths as inputs for the test command in turbo.json to enhance test execution context.

github-actions bot added arkenv Changes to the `arkenv` npm package. @arkenv/vite-plugin Issues or Pull Requests involving the Vite plugin for ArkEnv labels Oct 12, 2025

github-actions bot added the www Improvements or additions to arkenv.js.org label Oct 12, 2025

vercel bot deployed to Preview October 12, 2025 18:30 View deployment

coderabbitai bot requested changes Oct 12, 2025

View reviewed changes

turbo.json Show resolved Hide resolved

chore: add inputs to test command in turbo.json

43ca656

- Included default and Vitest configuration file paths as inputs for the test command in turbo.json to enhance test execution context.

coderabbitai bot approved these changes Oct 12, 2025

View reviewed changes

vercel bot deployed to Preview October 12, 2025 18:37 View deployment

yamcodes merged commit d667be7 into main Oct 12, 2025
16 of 17 checks passed

yamcodes deleted the turborepo-fixes-best-practices branch October 12, 2025 18:38

This was referenced Oct 12, 2025

Automatic boolean string conversion #218

Merged

Set up Playwright #229

Merged

Simplify testing configuration #238

Merged

This was referenced Nov 3, 2025

Improve e2e speed #270

Merged

feat(tests): enhance CI workflow and Playwright configuration #279

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Turborepo fixes (Best practices)#216

Turborepo fixes (Best practices)#216
yamcodes merged 3 commits intomainfrom
turborepo-fixes-best-practices

yamcodes commented Oct 12, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

changeset-bot bot commented Oct 12, 2025 •

edited

Loading

Uh oh!

vercel bot commented Oct 12, 2025 •

edited

Loading

Uh oh!

coderabbitai bot commented Oct 12, 2025 •

edited

Loading

Review failed

Uh oh!

pkg-pr-new bot commented Oct 12, 2025 •

edited

Loading

Uh oh!

coderabbitai bot left a comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

yamcodes commented Oct 12, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

changeset-bot bot commented Oct 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

vercel bot commented Oct 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai bot commented Oct 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review failed

Walkthrough

Changes

Sequence Diagram(s)

Estimated code review effort

Possibly related PRs

Suggested labels

Poem

Pre-merge checks and finishing touches

Uh oh!

pkg-pr-new bot commented Oct 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

yamcodes commented Oct 12, 2025 •

edited by coderabbitai bot

Loading

changeset-bot bot commented Oct 12, 2025 •

edited

Loading

vercel bot commented Oct 12, 2025 •

edited

Loading

coderabbitai bot commented Oct 12, 2025 •

edited

Loading

pkg-pr-new bot commented Oct 12, 2025 •

edited

Loading