Skip to content

Fix: "Star us" button now glows orange in light mode #171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yamcodes merged 7 commits into from
Sep 15, 2025
Merged

Fix: "Star us" button now glows orange in light mode #171

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
c051d74
Initial plan
Copilot Sep 14, 2025
f90287a
Fix: Add orange glow to "Star us" button in light mode
Copilot Sep 14, 2025
69fb390
Fix: Use direct RGB values in shadow instead of CSS custom properties
Copilot Sep 15, 2025
cdddbca
Refactor: Implement variant-based styling for StarUsButton component
yamcodes Sep 15, 2025
a7ffd5c
Enhance StarUsButton styles for improved mobile and desktop variants
yamcodes Sep 15, 2025
2714732
Merge branch 'main' into copilot/fix-170
yamcodes Sep 15, 2025
31a6f8f
Refactor StarUsButton shadow styles to use direct RGBA values
yamcodes Sep 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
80 changes: 62 additions & 18 deletions apps/www/components/page/star-us-button.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,68 @@
"use client";

import { SiGithub } from "@icons-pack/react-simple-icons";
import { cva, type VariantProps } from "class-variance-authority";
import { Star } from "lucide-react";
import { useEffect, useState } from "react";
import { Button } from "~/components/ui/button";
import { cn } from "~/lib/utils/cn";

const starUsButtonVariants = cva("text-lg font-bold", {
variants: {
variant: {
mobile: [
"w-full",
"bg-gradient-to-r from-yellow-50 to-orange-50",
"hover:bg-gradient-to-r hover:from-yellow-100 hover:to-orange-100",
"dark:from-yellow-900/20 dark:to-orange-900/20",
"dark:hover:from-yellow-900/30 dark:hover:to-orange-900/30",
"border-2 border-yellow-200 dark:border-yellow-700",
"text-yellow-800 dark:text-yellow-200",
"hover:text-yellow-800 dark:hover:text-yellow-200",
"transition-colors duration-200",
],
desktop: [
"relative overflow-hidden cursor-pointer",
"bg-gradient-to-r from-yellow-50 to-orange-50",
"dark:from-yellow-900/20 dark:to-orange-900/20",
"border-2 border-yellow-200 dark:border-yellow-700",
"text-yellow-800 dark:text-yellow-200",
"hover:text-yellow-800 dark:hover:text-yellow-200",
"transition-all duration-200 ease-in-out scale-100",
"focus-visible:ring-2 focus-visible:ring-[rgba(255,150,0,0.7)] focus-visible:ring-offset-0",
"hover:scale-105",
],
},
},
defaultVariants: {
variant: "mobile",
},
});

const starUsShadowVariants = cva(
"absolute inset-0 rounded-lg pointer-events-none",
{
variants: {
variant: {
mobile: [
"shadow-[0_8px_16px_rgba(255,150,0,0.1)]",
"dark:shadow-[0_8px_16px_rgba(255,150,0,0.15)]",
],
desktop: [
"shadow-[0_16px_20px_rgba(255,150,0,0.1)]",
"dark:shadow-[0_16px_20px_rgba(255,150,0,0.15)]",
],
},
},
defaultVariants: {
variant: "desktop",
},
},
);

type StarUsProps = {
className?: string;
};
} & VariantProps<typeof starUsButtonVariants>;
Copy link

@cursor cursor bot Sep 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Button Component Ignores Variant Prop

The StarUsProps type includes a variant prop, but the StarUsButton component only destructures className. Since the button variants are hardcoded in the JSX, any variant prop passed to the component is ignored, creating a mismatch between the type definition and actual behavior.

Fix in Cursor Fix in Web


export function StarUsButton({ className }: StarUsProps) {
const [starCount, setStarCount] = useState<number | null>(null);
Expand Down Expand Up @@ -65,19 +119,15 @@ export function StarUsButton({ className }: StarUsProps) {
`}</style>

{/* Mobile: Simple button with glow */}
<div className="sm:hidden w-full">
<div className="sm:hidden w-full relative">
{/* Shadow element for mobile */}
<div className={starUsShadowVariants({ variant: "mobile" })} />

<Button
asChild
variant="outline"
size="lg"
className={cn(
"w-full text-lg font-bold shadow-[0_8px_16px] [--tw-shadow-color:rgba(255,150,0,0.2)] dark:[--tw-shadow-color:rgba(255,150,0,0.2)]",
"bg-gradient-to-r from-yellow-50 to-orange-50 dark:from-yellow-900/20 dark:to-orange-900/20",
"border-2 border-yellow-200 dark:border-yellow-700",
"text-yellow-800 dark:text-yellow-200 hover:text-yellow-800 dark:hover:text-yellow-200",
"transition-colors duration-200",
className,
)}
className={cn(starUsButtonVariants({ variant: "mobile" }), className)}
>
<a
href={
Expand Down Expand Up @@ -107,20 +157,14 @@ export function StarUsButton({ className }: StarUsProps) {
{/* Desktop: Complex button with animations and effects */}
<div className="hidden sm:block relative">
{/* Shadow element that doesn't scale */}
<div className="absolute inset-0 rounded-lg shadow-[0_16px_20px] [--tw-shadow-color:rgba(255,150,0,0.15)] dark:[--tw-shadow-color:rgba(255,150,0,0.15)] pointer-events-none" />
<div className={starUsShadowVariants({ variant: "desktop" })} />

<Button
asChild
variant="outline"
size="lg"
className={cn(
"relative overflow-hidden cursor-pointer text-lg font-bold",
"bg-gradient-to-r from-yellow-50 to-orange-50 dark:from-yellow-900/20 dark:to-orange-900/20",
"border-2 border-yellow-200 dark:border-yellow-700",
"text-yellow-800 dark:text-yellow-200 hover:text-yellow-800 dark:hover:text-yellow-200",
"transition-all duration-200 ease-in-out scale-100",
"focus-visible:ring-2 focus-visible:ring-[rgba(255,150,0,0.7)] focus-visible:ring-offset-0",
"hover:scale-105",
starUsButtonVariants({ variant: "desktop" }),
className,
)}
>
Expand Down
Loading