Skip to content

Commit

Permalink
cpus.c: add additional error_report when !TARGET_SUPPORT_MTTCG
Browse files Browse the repository at this point in the history
While we may fail the memory ordering check later that can be
confusing. So in cases where TARGET_SUPPORT_MTTCG has yet to be
defined we should say so specifically.

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Richard Henderson <rth@twiddle.net>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
  • Loading branch information
stsquad committed Mar 9, 2017
1 parent 72c1701 commit c34c762
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions cpus.c
Original file line number Diff line number Diff line change
Expand Up @@ -202,6 +202,10 @@ void qemu_tcg_configure(QemuOpts *opts, Error **errp)
} else if (use_icount) {
error_setg(errp, "No MTTCG when icount is enabled");
} else {
#ifndef TARGET_SUPPORT_MTTCG
error_report("Guest not yet converted to MTTCG - "
"you may get unexpected results");
#endif
if (!check_tcg_memory_orders_compatible()) {
error_report("Guest expects a stronger memory ordering "
"than the host provides");
Expand Down

0 comments on commit c34c762

Please sign in to comment.