Skip to content

Commit

Permalink
pc: acpi: cpu-hotplug: make AML CPU_foo defines local to cpu_hotplug_…
Browse files Browse the repository at this point in the history
…acpi_table.c

now as those defines are used only locally inside of
cpu_hotplug_acpi_table.c, move them out of header file.

Signed-off-by: Igor Mammedov <imammedo@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Reviewed-by: Marcel Apfelbaum <marcel@redhat.com>
  • Loading branch information
Igor Mammedov authored and mstsirkin committed Jun 7, 2016
1 parent 8edf77e commit a630bb3
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 7 deletions.
7 changes: 7 additions & 0 deletions hw/acpi/cpu_hotplug_acpi_table.c
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,13 @@
#include "hw/acpi/cpu_hotplug.h"
#include "hw/i386/pc.h"

#define CPU_EJECT_METHOD "CPEJ"
#define CPU_MAT_METHOD "CPMA"
#define CPU_ON_BITMAP "CPON"
#define CPU_STATUS_METHOD "CPST"
#define CPU_STATUS_MAP "PRS"
#define CPU_SCAN_METHOD "PRSC"

void build_cpu_hotplug_aml(Aml *ctx, MachineState *machine,
uint16_t io_base, uint16_t io_len)
{
Expand Down
7 changes: 0 additions & 7 deletions include/hw/acpi/cpu_hotplug.h
Original file line number Diff line number Diff line change
Expand Up @@ -27,13 +27,6 @@ void acpi_cpu_plug_cb(ACPIREGS *ar, qemu_irq irq,
void acpi_cpu_hotplug_init(MemoryRegion *parent, Object *owner,
AcpiCpuHotplug *gpe_cpu, uint16_t base);

#define CPU_EJECT_METHOD "CPEJ"
#define CPU_MAT_METHOD "CPMA"
#define CPU_ON_BITMAP "CPON"
#define CPU_STATUS_METHOD "CPST"
#define CPU_STATUS_MAP "PRS"
#define CPU_SCAN_METHOD "PRSC"

void build_cpu_hotplug_aml(Aml *ctx, MachineState *machine,
uint16_t io_base, uint16_t io_len);
#endif

0 comments on commit a630bb3

Please sign in to comment.