Skip to content

Commit

Permalink
memory: cpu_physical_memory_set_dirty_tracking() should return void
Browse files Browse the repository at this point in the history
Result was always 0, and not used anywhere.  Once there, use bool type
for the parameter.

Signed-off-by: Juan Quintela <quintela@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Orit Wasserman <owasserm@redhat.com>
  • Loading branch information
Juan Quintela committed Jan 13, 2014
1 parent a2f4d5b commit 981fdf2
Showing 1 changed file with 4 additions and 6 deletions.
10 changes: 4 additions & 6 deletions exec.c
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@
//#define DEBUG_SUBPAGE

#if !defined(CONFIG_USER_ONLY)
static int in_migration;
static bool in_migration;

RAMList ram_list = { .blocks = QTAILQ_HEAD_INITIALIZER(ram_list.blocks) };

Expand Down Expand Up @@ -752,11 +752,9 @@ void cpu_physical_memory_reset_dirty(ram_addr_t start, ram_addr_t length,
}
}

static int cpu_physical_memory_set_dirty_tracking(int enable)
static void cpu_physical_memory_set_dirty_tracking(bool enable)
{
int ret = 0;
in_migration = enable;
return ret;
}

hwaddr memory_region_section_get_iotlb(CPUArchState *env,
Expand Down Expand Up @@ -1798,12 +1796,12 @@ static void tcg_commit(MemoryListener *listener)

static void core_log_global_start(MemoryListener *listener)
{
cpu_physical_memory_set_dirty_tracking(1);
cpu_physical_memory_set_dirty_tracking(true);
}

static void core_log_global_stop(MemoryListener *listener)
{
cpu_physical_memory_set_dirty_tracking(0);
cpu_physical_memory_set_dirty_tracking(false);
}

static MemoryListener core_memory_listener = {
Expand Down

0 comments on commit 981fdf2

Please sign in to comment.