Skip to content

Commit

Permalink
pci: pci.h cleanup: move out stuff not in pci.c
Browse files Browse the repository at this point in the history
pci.h declares some functions which aren't
defined in pci.h. Clean up moving things
to appropriate headers, and update all users.

Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
  • Loading branch information
mstsirkin committed Dec 1, 2009
1 parent 3098b9f commit 18e08a5
Show file tree
Hide file tree
Showing 23 changed files with 76 additions and 25 deletions.
1 change: 1 addition & 0 deletions hw/apb_pci.c
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@
#include "sysbus.h"
#include "pci.h"
#include "pci_host.h"
#include "apb_pci.h"

/* debug APB */
//#define DEBUG_APB
Expand Down
9 changes: 9 additions & 0 deletions hw/apb_pci.h
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
#ifndef APB_PCI_H
#define APB_PCI_H

#include "qemu-common.h"

PCIBus *pci_apb_init(target_phys_addr_t special_base,
target_phys_addr_t mem_base,
qemu_irq *pic, PCIBus **bus2, PCIBus **bus3);
#endif
2 changes: 2 additions & 0 deletions hw/lsi53c895a.c
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,8 @@ do { fprintf(stderr, "lsi_scsi: error: " fmt , ## __VA_ARGS__); exit(1);} while
do { fprintf(stderr, "lsi_scsi: error: " fmt , ## __VA_ARGS__);} while (0)
#endif

#define LSI_MAX_DEVS 7

#define LSI_SCNTL0_TRG 0x01
#define LSI_SCNTL0_AAP 0x02
#define LSI_SCNTL0_EPC 0x08
Expand Down
2 changes: 2 additions & 0 deletions hw/mips_malta.c
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,8 @@
#include "flash.h"
#include "mips.h"
#include "pci.h"
#include "usb-uhci.h"
#include "vmware_vga.h"
#include "qemu-char.h"
#include "sysemu.h"
#include "audio/audio.h"
Expand Down
5 changes: 5 additions & 0 deletions hw/pc.c
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,11 @@
#include "pc.h"
#include "fdc.h"
#include "pci.h"
#include "vmware_vga.h"
#include "usb-uhci.h"
#include "usb-ohci.h"
#include "prep_pci.h"
#include "apb_pci.h"
#include "block.h"
#include "sysemu.h"
#include "audio/audio.h"
Expand Down
25 changes: 0 additions & 25 deletions hw/pci.h
Original file line number Diff line number Diff line change
Expand Up @@ -413,31 +413,6 @@ static inline uint32_t pci_config_size(PCIDevice *d)
return pci_is_express(d) ? PCIE_CONFIG_SPACE_SIZE : PCI_CONFIG_SPACE_SIZE;
}

/* lsi53c895a.c */
#define LSI_MAX_DEVS 7

/* vmware_vga.c */
void pci_vmsvga_init(PCIBus *bus);

/* usb-uhci.c */
void usb_uhci_piix3_init(PCIBus *bus, int devfn);
void usb_uhci_piix4_init(PCIBus *bus, int devfn);

/* usb-ohci.c */
void usb_ohci_init_pci(struct PCIBus *bus, int devfn);

/* prep_pci.c */
PCIBus *pci_prep_init(qemu_irq *pic);

/* apb_pci.c */
PCIBus *pci_apb_init(target_phys_addr_t special_base,
target_phys_addr_t mem_base,
qemu_irq *pic, PCIBus **bus2, PCIBus **bus3);

/* sh_pci.c */
PCIBus *sh_pci_register_bus(pci_set_irq_fn set_irq, pci_map_irq_fn map_irq,
void *pic, int devfn_min, int nirq);

/* These are not pci specific. Should move into a separate header.
* Only pci.c uses them, so keep them here for now.
*/
Expand Down
1 change: 1 addition & 0 deletions hw/ppc_newworld.c
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@
#include "nvram.h"
#include "pc.h"
#include "pci.h"
#include "usb-ohci.h"
#include "net.h"
#include "sysemu.h"
#include "boards.h"
Expand Down
1 change: 1 addition & 0 deletions hw/ppc_oldworld.c
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@
#include "net.h"
#include "isa.h"
#include "pci.h"
#include "usb-ohci.h"
#include "boards.h"
#include "fw_cfg.h"
#include "escc.h"
Expand Down
2 changes: 2 additions & 0 deletions hw/ppc_prep.c
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,8 @@
#include "sysemu.h"
#include "isa.h"
#include "pci.h"
#include "prep_pci.h"
#include "usb-ohci.h"
#include "ppc.h"
#include "boards.h"
#include "qemu-log.h"
Expand Down
1 change: 1 addition & 0 deletions hw/prep_pci.c
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@
#include "hw.h"
#include "pci.h"
#include "pci_host.h"
#include "prep_pci.h"

typedef PCIHostState PREPPCIState;

Expand Down
8 changes: 8 additions & 0 deletions hw/prep_pci.h
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
#ifndef QEMU_PREP_PCI_H
#define QEMU_PREP_PCI_H

#include "qemu-common.h"

PCIBus *pci_prep_init(qemu_irq *pic);

#endif
1 change: 1 addition & 0 deletions hw/r2d.c
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@
#include "sysemu.h"
#include "boards.h"
#include "pci.h"
#include "sh_pci.h"
#include "net.h"
#include "sh7750_regs.h"
#include "ide.h"
Expand Down
1 change: 1 addition & 0 deletions hw/realview.c
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
#include "primecell.h"
#include "devices.h"
#include "pci.h"
#include "usb-ohci.h"
#include "net.h"
#include "sysemu.h"
#include "boards.h"
Expand Down
1 change: 1 addition & 0 deletions hw/sh_pci.c
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@
#include "hw.h"
#include "sh.h"
#include "pci.h"
#include "sh_pci.h"
#include "bswap.h"

typedef struct {
Expand Down
9 changes: 9 additions & 0 deletions hw/sh_pci.h
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
#ifndef QEMU_SH_PCI_H
#define QEMU_SH_PCI_H

#include "qemu-common.h"

PCIBus *sh_pci_register_bus(pci_set_irq_fn set_irq, pci_map_irq_fn map_irq,
void *pic, int devfn_min, int nirq);

#endif
1 change: 1 addition & 0 deletions hw/sun4u.c
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
*/
#include "hw.h"
#include "pci.h"
#include "apb_pci.h"
#include "pc.h"
#include "nvram.h"
#include "fdc.h"
Expand Down
1 change: 1 addition & 0 deletions hw/usb-ohci.c
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@
#include "pci.h"
#include "pxa.h"
#include "devices.h"
#include "usb-ohci.h"

//#define DEBUG_OHCI
/* Dump packet contents. */
Expand Down
9 changes: 9 additions & 0 deletions hw/usb-ohci.h
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
#ifndef QEMU_USB_OHCI_H
#define QEMU_USB_OHCI_H

#include "qemu-common.h"

void usb_ohci_init_pci(struct PCIBus *bus, int devfn);

#endif

1 change: 1 addition & 0 deletions hw/usb-uhci.c
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@
#include "usb.h"
#include "pci.h"
#include "qemu-timer.h"
#include "usb-uhci.h"

//#define DEBUG
//#define DEBUG_DUMP_DATA
Expand Down
9 changes: 9 additions & 0 deletions hw/usb-uhci.h
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
#ifndef QEMU_USB_UHCI_H
#define QEMU_USB_UHCI_H

#include "qemu-common.h"

void usb_uhci_piix3_init(PCIBus *bus, int devfn);
void usb_uhci_piix4_init(PCIBus *bus, int devfn);

#endif
1 change: 1 addition & 0 deletions hw/versatilepb.c
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
#include "net.h"
#include "sysemu.h"
#include "pci.h"
#include "usb-ohci.h"
#include "boards.h"

/* Primary interrupt controller. */
Expand Down
1 change: 1 addition & 0 deletions hw/vmware_vga.c
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@
#include "hw.h"
#include "console.h"
#include "pci.h"
#include "vmware_vga.h"

#define VERBOSE
#undef DIRECT_VRAM
Expand Down
9 changes: 9 additions & 0 deletions hw/vmware_vga.h
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
#ifndef QEMU_VMWARE_VGA_H
#define QEMU_VMWARE_VGA_H

#include "qemu-common.h"

/* vmware_vga.c */
void pci_vmsvga_init(PCIBus *bus);

#endif

0 comments on commit 18e08a5

Please sign in to comment.