Skip to content

Commit

Permalink
storcon_cli: don't clobber heatmap interval when setting eviction (ne…
Browse files Browse the repository at this point in the history
…ondatabase#8722)

## Problem

This command is kind of a hack, used when we're migrating large tenants
and want to get their resident size down. It sets the tenant config to a
fixed value, which omitted heatmap_period, so caused secondaries to get
out of date.

## Summary of changes

- Set heatmap period to the same 300s default that we use elsewhere when
updating eviction settings

This is not as elegant as some general purpose partial modification of
the config, but it practically makes the command safer to use.
  • Loading branch information
jcsp authored Aug 14, 2024
1 parent a7028d9 commit abb53ba
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions control_plane/storcon_cli/src/main.rs
Original file line number Diff line number Diff line change
Expand Up @@ -622,6 +622,7 @@ async fn main() -> anyhow::Result<()> {
threshold: threshold.into(),
},
)),
heatmap_period: Some("300s".to_string()),
..Default::default()
},
})
Expand Down

0 comments on commit abb53ba

Please sign in to comment.