Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent deserialization problem with Espionage #9809

Merged
merged 2 commits into from
Jul 18, 2023

Conversation

SomeTroglodyte
Copy link
Collaborator

There was an issue where I commented on this, but can't find it.
With current master, no save can be reloaded that has a non-empty erasSpyEarnedFor.

  • Too much comment?
  • Sniffing into Espionage - I would be tempted to allow unique quotes and portraits per individual Spy, at least as Mod. Imagine a mugshot taken from wikipedia plus the quote "A harlot? Yes, but a traitoress, never! - Phrase attributed to margaretha Zelle during the trial" for "Mata Hari"...
    Civ5 itself seem not to have such a feature... Yes/No, and if Yes - data schema? Extra Json, mapping decorations per Spy name / deprecate spyNames in favour of an array of SpyMetadata objects / custom deserializer that reads both? Display on-click in Espionage screen or on getting a Spy as AlertPopup like the Tech/Wonder quotes?

@yairm210
Copy link
Owner

Yeah you're commenting why you make the change, but the next dev who comes will be like 'why is it taking about mutableSetOf if it doesn't appear anywhere?"

@SomeTroglodyte
Copy link
Collaborator Author

I thought that read "do not use..." But then maybe the whole comment should go on IsPartOfGameInfoSerialization instead..

@yairm210 yairm210 merged commit 37465b5 into yairm210:master Jul 18, 2023
@SomeTroglodyte SomeTroglodyte deleted the Espionage branch July 19, 2023 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants