Avoid built buildings #9806
Merged
Avoid built buildings #9806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR attempts to removes almost every call to cityConstructions.builtBuildings. Most other systems does not use it (it uses builtBuildingObjects in some way or form) and it opens the way for possible other bugs. The primary places where it was left was in setTransients, the add/remove functions, the clone function, and any places where the other PR of mine already removed the intraction. The only place where I'm not sure builtBuildingObjects is necessarily better is for the wonder overview tab, but everything else should be consistent with how it looks like it should be used
There's the function for
changeBuildingNameIfNotInRuleset. From what I can tell, it's currently only used for the Hanse, it was done 2 years ago (past deprecation period likely), and seems imo more likely to cause issues in mods than it is to help (given it was done 2 years ago). This PR removes the call to the function for now