Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

City-level resources #9774

Merged
merged 6 commits into from
Jul 10, 2023
Merged

City-level resources #9774

merged 6 commits into from
Jul 10, 2023

Conversation

yairm210
Copy link
Owner

@yairm210 yairm210 commented Jul 9, 2023

Allows designating resources as city-level resources (think: Civ VI artifact slots/power, Civ IV 'health', etc)

What's really cool is that resources from tiles work as expected, which means you can make city-specific resource chains all the way from base tiles :D

City-level resources are...

  • Not displayed in civ top bar
  • Not considered civ-level resources (for trade, non-city conditionals, etc)
  • Are explicitly treated in city conditionals
  • ARE considered for constructing buildings requiring resource
  • ARE NOT considered for construction units requiring resource

Example (Civ6 mod, Districts):
image

@SeventhM Since you're the primary "modder and dev" I would like your feedback on this

- Not displayed in civ top bar
- Not considered civ-level resources (for trade, non-city conditionals, etc)
- Are explicitly treated in city conditionals
- ARE considered for constructing buildings requiring resource
- ARE NOT considered for construction units requiring resource
@yairm210 yairm210 requested a review from SomeTroglodyte July 9, 2023 09:19
@SeventhM
Copy link
Collaborator

SeventhM commented Jul 9, 2023

Sorta looking at it at a quick glance rn, will probably look with further detail later, but

  • ARE NOT considered for construction units requiring resource

Is there a way to make it considered for constructing units? I could see a modder try to use this as a more fine grained way to limit how many of a type of unit you get per city

@yairm210
Copy link
Owner Author

yairm210 commented Jul 9, 2023

That sounds way out of scope - that would mean we need to track what unit came from what city, and deal with situations like what happens if the city is taken over/destroyed

@SeventhM
Copy link
Collaborator

SeventhM commented Jul 9, 2023

Looks fine enough to me at first look over. If anything, I wish there was some way to view where each source of the resource is coming from (even if it's just "this is from buildings, that from improvements") in the city view, but I'm not sure on how the ui should look on that one. Probably a question to ask the discord

Copy link
Collaborator

@SomeTroglodyte SomeTroglodyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

requested your review on this pull request.

Quel honneur!

OK: Veni, nitlecta, sed nulli praevaricatores vidi.

@yairm210 yairm210 merged commit ee092a5 into master Jul 10, 2023
@yairm210 yairm210 deleted the city-resources branch July 10, 2023 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants