Fix issues from gaining free beliefs

[SeventhM]

• Fixes Gain a free [Any] belief causing an infinite loop (it wasn't decrementing the amount of "any" belief you got, instead decrementing the belief type of the one you gained. You would get stuck choosing every belief until there is no more)
• Fixes beliefs chosen when using a prophet reducing the amount of free beliefs you got. Previously, it would count as using a free belief if you were choosing beliefs post prophet use, regardless of if you actually were choosing free beliefs or not. That would decrement the amount of free beliefs when it shouldn't

---

Leaving this as a draft initially as there's still a few things I'm not sure is ideal

1. If you get multiple pantheons upon founding a pantheon, you have to choose them one at a time. The picker screen as is doesn't allow for picking more than one. Not surer if it's out of scope to fix that here, but it seems unnecessarily slow to get multiple pantheons
2. It seems weird to me that free beliefs are chosen separately than prophet beliefs, especially given how Byzantium works. I'm aware doing things like that is technically how Civ 5 works, but it seems unnecessarily tedious and it comes with a few side effects. Namely, if you just picked free beliefs when you got them, even when you get them from founding/enhancing, you wouldn't actually need the extra step of tracking which came from "Any" and which didn't. We can just clear all of the free beliefs and call it a day
3. Speaking of tracking where a belief is being chosen, I'm almost certain the helper class in NextTurnAutomation (which I copied from the religion screen) is misplaced. Not sure where it should be

[SomeTroglodyte]

1. Not surer if it's out of scope to fix that here

Never wrong to separate logic fixes from UI QOL improvements

Apologies for not helping on the other questions, they're good ones requiring some code inspection, too tired for that.

[SeventhM]

@SomeTroglodyte I'm confused as to why this was closed

[SomeTroglodyte]

confused

Me too, but if github says it was me, must have misclicked. (!!sorry!!)

[SomeTroglodyte]

I've never seen the next turn button show "Reform Religion", not even playing Byzantium - how do you even get there?

[SomeTroglodyte]

If you get multiple pantheons upon founding a pantheon

This is certainly Mod-only, right? Which mod does that?

[SeventhM]

next turn button show "Reform Religion"

You get it from the Gain a free [beliefType] belief unique. Which behaves differently than Byzantium's May choose [amount] additional belief(s) of any type when [foundingOrEnhancing] a religion. The former unique will give you a free believe, which gives you the "Reform Religion" text on the next turn button. The latter will just give you the beliefs as you found/enhance

This is certainly Mod-only, right? Which mod does that?

Tbh, not sure. I actually found this more by messing with my test version of Rekmod where I edit everything around

[SomeTroglodyte]

found this more by messing

Okay, that explains some of my confusion. That Unique - it's triggered? Say, by a Policy? What if you haven't got a Religion and the trigger happens? Stop stop stop stop - that way only headaches find you can.

Also, if it doesn't affect any game I might be playing - my egoism says go ahead merge whatever you want 😈

No, seriously: I would need to see the problem or the solution in operation to really judge, and if there's no input to make that a 2-minute setup,... Thus, looking from the entirely other angle, take a step back:

• Free stuff triggers. AI simply processes them specific to generic, no problem. (say, same trigger gives 1 any, 1 follower) ... at least looking from a distance that shouldn't be a problem, right?
• Free stuff triggers for meatbag player. Can be cleanly done entirely within the picker - easy if you don't allow close until done, or if the free-counts are persistable, even piecemeal, if you do the same as AI above - keep accounts in the picker and deduct from most specific applicable?
• Pantheons - just make sure the specific Pantheon picker is only used when the free accounts sum up to just one Pantheon. Use the other (found/enhance) picker in all other cases. Not optimal, but still less clicks. And UX improvement there is imaginable (is double-click used? Preselect next open slot on the left side when a choice is made on the right?) and then benefit un-modded games too.

Mind you, that's expectations when forgetting the details. If such expectations are reasonable and still don't hold in implementation, look for the blockers first instead of for workarounds, right?

[SeventhM]

What if you haven't got a Religion and the trigger happens

I actually already looked through for the answer to this to make sure I wasn't breaking things. It actually doesn't give you the free belief unless it's a free pantheon or a free "any" belief. There it will give you the free belief as a pantheon, even if you got an "any"

just make sure the specific Pantheon picker is only used

At that point I question why we're even using the pantheon picker in the first place. The rest of the religion picker works just fine for 1 pantheon as it does for 5. If I was to address it from a UI standpoint, I would rather either use the pantheon picker for the first pantheon and use the religion picker for everything else (to see what you've already picked), use the pantheon picker for all things before founding a major religion and just allow for picking more than one pantheon, or just use the religion picker for everything

keep accounts in the picker and deduct from most specific applicable

But at that point, if you're keeping people in the picker, it seems to me like we should just treat the free belief unique and the byzantium unique the same and just show all of them when you enter the the religion picker instead of picking your founder beliefs, then picking the free beliefs that you got from founding

[SomeTroglodyte]

At that point I question

Precisely.

just show all of them

I think that was what I had in mind... As I said, stepped waaaaay back to initial user story + wishful thinking + prejudices; no code..

[SeventhM]

Ok, Reverting some of the changes outside of the religion manager if we're having free beliefs immediately be available upon founding/expanding. This still doesn't fix the ui issues I have with the pantheon picker (again, probably outside of scope), but it's good enough for me to be willing to have it merged

Known issue that I may look into as a separate PR: we need to limit the amount of free beliefs by the amount of available beliefs a bit more often than we currently do. It is possible (and seemingly was always possible) to have more free beliefs than there are available beliefs after a different civ founds. It doesn't seem worth fixing that in this PR, but it is something I noticed