Skip to content

AbsoluteUnits - Unique Triremes #8354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 11, 2023
Merged

AbsoluteUnits - Unique Triremes #8354

merged 2 commits into from
Jan 11, 2023

Conversation

letstalkaboutdune
Copy link
Contributor

Unique_Trireme

Also increased banner size (2x each dimension) as the previous looked very small, and fixed a typo in a Steam asset filename.

Also increased banner size (2x each dimension) and fixed a typo in a Steam asset filename
@yairm210
Copy link
Owner

We display the banner at full size, and on phones - where default is portrait mode - this means the banner will be to wide to fit in the screen.
I'll have to test how this looks and perhaps make changes.

@letstalkaboutdune
Copy link
Contributor Author

letstalkaboutdune commented Jan 10, 2023

We display the banner at full size, and on phones - where default is portrait mode - this means the banner will be to wide to fit in the screen. I'll have to test how this looks and perhaps make changes.

I thought phone default was landscape mode, and portrait mode had to be enabled with an option. But if we can determine a good resolution, then I'll happily use that. Maybe 2x each dimension is too much.

@letstalkaboutdune
Copy link
Contributor Author

I shrank the banner back down to the original size, because I don't want that issue delaying the release of the new unique sprites.

@yairm210 yairm210 merged commit e417c67 into yairm210:master Jan 11, 2023
@yairm210
Copy link
Owner

Please make a new pr including only the bigger banner, for testing 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants