Skip to content

Platform Graphical Asset Update #8343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 9, 2023
Merged

Platform Graphical Asset Update #8343

merged 3 commits into from
Jan 9, 2023

Conversation

letstalkaboutdune
Copy link
Contributor

Updated repository graphical assets to match latest versions being used on all storefronts

Updated repository graphical assets to match latest versions being used on all storefronts
@letstalkaboutdune
Copy link
Contributor Author

Any idea why this would fail a check? I only added/updated image files.

@yairm210
Copy link
Owner

yairm210 commented Jan 9, 2023

The tests are ok
The github preview image is supposed to be a screenshot, that's what I want people to see first thing. I'm not sure what I want for Google Play.

@yairm210
Copy link
Owner

yairm210 commented Jan 9, 2023

Also for the banner - since you've changed the size significantly, we'll need to see how that renders on phones

@yairm210 yairm210 closed this Jan 9, 2023
@yairm210 yairm210 reopened this Jan 9, 2023
@letstalkaboutdune
Copy link
Contributor Author

letstalkaboutdune commented Jan 9, 2023

The tests are ok The github preview image is supposed to be a screenshot, that's what I want people to see first thing. I'm not sure what I want for Google Play.

I changed GitHub back to a screenshot, but updated it to the most recent one with all AU sprites. I also resized the banner to roughly match the old one.

I think that Google Play and Itch cover/feature images shouldn't be screenshots, since there are separate areas for screenshots for both of those platforms. Looking at every other app, the featured image contains the logo and non-screenshot artwork.

@yairm210 yairm210 merged commit 9600a25 into yairm210:master Jan 9, 2023
@letstalkaboutdune letstalkaboutdune deleted the Readme branch January 9, 2023 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants