Modding: allow custom ResourcePortraits

[vegeta1k95]

Allow for mods to add optional ResourcePortraits with un-tinted background.
Example:

[github-actions]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[vegeta1k95]

Okay, so I did generification of almost all entities icons to account for moddable optional portraits with custom backgrounds. This includes:

• Units
• Buildings
• Techs
• Resources
• Improvements
• Promotions
• UnitActions
• Religions
• Nations
• Uniques

Each of these instances now can have optional untinted portraits with custom background.
If portrait is absent it resorts to icons.

This doesn't influence base game, so for modding convenience only.

[AdityaMH]

if player using resources portait mods, they can't know what resources type. luxury or bonus resources each item.

[yairm210]

Out of 'else', since if the previous if was true it returns

[yairm210]

Code looks ok, but I'll want some pics

One screenshot, with a promoted unit selected and a city button visible, can probably contain almost all of these:

Units
Buildings
Techs
Resources
Improvements
Promotions
UnitActions
Religions
Nations

Only for Uniques do we need a screenshot of the tech table

[vegeta1k95]

Here is everything except religions and uniques (Mod is "Civ 5 Icons")

Here is techs (building, units, res, improvements, uniques):

Here is religion:

[vegeta1k95]

City View:

[vegeta1k95]

if player using resources portait mods, they can't know what resources type. luxury or bonus resources each item.

That's a modder's problem. He can make different portraits/add indicators to them to distinguish types. or as a last measure resort to using icons.

[yairm210]

That's good, but I was pretty sure that works since that's what you set out to do :)
What I want is to ensure that the regular, non-portrait view still looks the same

[vegeta1k95]

Here same without mods:

Nothing changed, except for Improvement Dimming, I don't know why they were dimmed in the first place, I could hardly see them even in default (they were half-transparent for some reason)

[vegeta1k95]

Idk how to resolve conflict tho. I pushed this at the same time with PromotionScreen rework and now it conflicts

[github-actions]

Conflicts have been resolved.