Fixed softlock forcing you to found a pantheon without available beliefs #7883
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Savefile to reproduce:
Invalid Pantheon Found.txt
The problem was that when you found a religion, a new
Religion
object is created, that shares a pantheonBelief
with your previous pantheon religion. Thus, just counting the amount of beliefs in each existingReligion
over-estimates the amount ofBeliefs
of typePantheon
actually used in the game. As we only check if the amount of beliefs left of a certain type equals 0, this check would in the save file above returntrue
, as there were -9Belief
s of typePantheon
left. By using a distinct, we ignore these doubly counted pantheons, and thus get the correct number.