Skip to content

Fixed softlock forcing you to found a pantheon without available beliefs #7883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 2, 2022

Conversation

xlenstra
Copy link
Collaborator

@xlenstra xlenstra commented Oct 2, 2022

Savefile to reproduce:
Invalid Pantheon Found.txt

The problem was that when you found a religion, a new Religion object is created, that shares a pantheon Belief with your previous pantheon religion. Thus, just counting the amount of beliefs in each existing Religion over-estimates the amount of Beliefs of type Pantheon actually used in the game. As we only check if the amount of beliefs left of a certain type equals 0, this check would in the save file above return true, as there were -9 Beliefs of type Pantheon left. By using a distinct, we ignore these doubly counted pantheons, and thus get the correct number.

@yairm210 yairm210 merged commit 364da94 into yairm210:master Oct 2, 2022
@xlenstra xlenstra deleted the fix-pantheon-soft-lock branch October 2, 2022 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants