Skip to content

Update religious AI; buying faith buildings, inquisitor AI updates #7454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

xlenstra
Copy link
Collaborator

@xlenstra xlenstra commented Jul 15, 2022

Removed the city-by-city AI and combined it into a civ-wide AI to have better overview over purchases. Slightly changed when missionaries and inquisitors are bought to better match the actual game situation. Bit of a waste to use inquisitors unless there is a massive gap in pressure amounts. Also updated the AI of missionaries and inquisitors themselves to match the new expectations. Most of the purchasing logic is inspired by the source code of the original, with changes where I though them fit.

Tested it a bit, and I've seen missionaries spread religions inside and outside of different nations. Inquisitors are also used offensively and defensively. Religious buildings are also purchased.

Also ticks of two boxes from #4290.

@xlenstra xlenstra marked this pull request as ready for review July 19, 2022 17:04
@xlenstra xlenstra changed the title Update AI for buying with Faith, allowing it to buy Faith buildings Update religious AI improvements; buying faith buildings, inquisitor AI updates Jul 20, 2022
@xlenstra xlenstra changed the title Update religious AI improvements; buying faith buildings, inquisitor AI updates Update religious AI; buying faith buildings, inquisitor AI updates Jul 20, 2022
@Azzurite
Copy link
Collaborator

Please don't "Resolve" my conversations, I also want to be able to "mark them done" (i.e. I verify that they are actually resolved to what I had in mind). You could use a 👍 or another reaction to mark them done for you?

Copy link
Collaborator

@Azzurite Azzurite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Played a little bit with it, looks good :)

Copy link
Collaborator

@OptimizedForDensity OptimizedForDensity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I had tried to do this in the past but got too caught up with trying to account for buying arbitrary units that beliefs let you purchase with faith (e.g., Holy Warriors in the base game) but this is a great start and a clear improvement. Approved pending a reply to my one comment (so go ahead and merge if you feel that it's unnecessary).

@OptimizedForDensity
Copy link
Collaborator

Also conflicts.

@xlenstra
Copy link
Collaborator Author

I'll look more into this saturday evening or sunday, bit busy with real life right now :)

@xlenstra
Copy link
Collaborator Author

Looks good to me. I had tried to do this in the past but got too caught up with trying to account for buying arbitrary units that beliefs let you purchase with faith (e.g., Holy Warriors in the base game) but this is a great start and a clear improvement. Approved pending a reply to my one comment (so go ahead and merge if you feel that it's unnecessary).

Should be fixed now

@OptimizedForDensity OptimizedForDensity merged commit 52d0814 into yairm210:master Jul 23, 2022
@xlenstra xlenstra deleted the buy-religious-buildings-AI branch July 23, 2022 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants