-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Update religious AI; buying faith buildings, inquisitor AI updates #7454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update religious AI; buying faith buildings, inquisitor AI updates #7454
Conversation
Please don't "Resolve" my conversations, I also want to be able to "mark them done" (i.e. I verify that they are actually resolved to what I had in mind). You could use a 👍 or another reaction to mark them done for you? |
core/src/com/unciv/logic/automation/civilization/ReligionAutomation.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Played a little bit with it, looks good :)
core/src/com/unciv/logic/automation/civilization/ReligionAutomation.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. I had tried to do this in the past but got too caught up with trying to account for buying arbitrary units that beliefs let you purchase with faith (e.g., Holy Warriors in the base game) but this is a great start and a clear improvement. Approved pending a reply to my one comment (so go ahead and merge if you feel that it's unnecessary).
Also conflicts. |
I'll look more into this saturday evening or sunday, bit busy with real life right now :) |
Should be fixed now |
Removed the city-by-city AI and combined it into a civ-wide AI to have better overview over purchases. Slightly changed when missionaries and inquisitors are bought to better match the actual game situation. Bit of a waste to use inquisitors unless there is a massive gap in pressure amounts. Also updated the AI of missionaries and inquisitors themselves to match the new expectations. Most of the purchasing logic is inspired by the source code of the original, with changes where I though them fit.
Tested it a bit, and I've seen missionaries spread religions inside and outside of different nations. Inquisitors are also used offensively and defensively. Religious buildings are also purchased.
Also ticks of two boxes from #4290.