Save uncaught exception to file #7247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This writes the uncaught exception to file. On Android, this file will (likely) be found in
SDCard/Android/data/com.unciv.app/lasterror.txtwhile on Desktop it's the same file but in the game's directory.Then we can just tell people on Android to upload this file, should make debugging crashes much easier, even without the crash appearing in the Google Play Console.
I also renamed
GameSavertoUncivFilesas it doesn't only handle the saving of games, but it also loads theGameSettings.jsonand soon™️ it'll also save Multiplayer games differently.