spectators can no longer move and attack with units after selecting them

[ofetios]

No matter what I do Github makes it hard to read so:
I added

if (!UncivGame.Current.gameInfo.currentPlayerCiv.isSpectator()) { 
    //code 
}

on the code when you right click after selecting a unit as this caused many issues mentioned in #4460

[SomeTroglodyte]

Oh, didn't see that issue when I did #7003. I think a if () return would be the better formatting.

Linking 4460 with "resolves" is a bit exaggerated - there's more loopholes listed there. Can't investigate the next week or so, but it sounds as if just a few more checks if () return might be in order - the difficulty being in finding how non-rightclick ensures the rules and to make sure these checks can "find each other" for the next coder coming along.

[Azzurite]

The "correct" fix is to use the exact same code for attacking when using rightclick attack and "normal" attack... But yeah, like @SomeTroglodyte says, if you still want this in, please at least make it a if (...) return instead?

[ofetios]

i reformatted but a correct fix would probably be better than this

[Azzurite]

Still better than not having it :)