-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Implement fastlane step 1 - minimal framework #6608
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
It seems the content of |
Not only swapped, Notpadqq somehow used an encoding Studio didn't like, so I let it choose. |
I separated this logic into a separate fine precisely so it could be run with node locally :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it intentional that the en-US/full_description.txt
is now empty, while the same file for de/
does contain the full description?
fine as in pay money for some transgression?
What??? I had them open side by side and AS in such a case even cleverly prepends enough path to distinguish them - should be impossible to fumble... |
The PR for the first to-do item is here - a major PITA to create that on gitlab. The direct edit persistently refuses any changes "someone else was faster than you" (impossible to be always the case), and the web IDE takes up to 5 minutes for each and every tiny step.... I have no idea how to deal with that "fast-forward merge is not possible", though. Rollback - too many unrelated mails from their gitlab bot. Update: Our friend linsui did it just now. |
* Implement fastlane step 1 - minimal framework * Implement fastlane step 1 - fix en/de swap, encoding and a typo * Implement fastlane step 1 - fix en-US description empty
This just might close #6587. Perhaps. Almost no idea how to actually test (I could merge into my master then fake a few commits for a changelog then go through the steps to trigger a version 701 there, just to see the script creating a file, but that's a lot of work, especially getting my master back into sync. Testing the F-Droid side by forking their server code and setting up my own f-repo is even more disproportionate).
Done
To-Do after this PR
Description
entirely (it overrides fastlane, all languages)P.S.: I snuck in an updated "MapEditor" phone image. I opted for an Europe map and the View tab.