Skip to content

Implement fastlane step 1 - minimal framework #6608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 26, 2022

Conversation

SomeTroglodyte
Copy link
Collaborator

@SomeTroglodyte SomeTroglodyte commented Apr 25, 2022

This just might close #6587. Perhaps. Almost no idea how to actually test (I could merge into my master then fake a few commits for a changelog then go through the steps to trigger a version 701 there, just to see the script creating a file, but that's a lot of work, especially getting my master back into sync. Testing the F-Droid side by forking their server code and setting up my own f-repo is even more disproportionate).

Done

  • Minimal required fastlane structure
  • Coded generation of changelogs/*.txt discrete files (this guide lists them as 'nice to have', but I think their importance is higher)
  • Made sure image sizes match recommendations where any can be found (192² for icon, 1024x500 for featureGraphic, both already available)
  • Fulfill requiremets to make it into the "Latest" spam as per this

To-Do after this PR

  • File a PR against Unciv's fdroiddata yml to remove Description entirely (it overrides fastlane, all languages)
  • Automate syncing android/res/drawable-xxxhdpi/uncivicon2.png to fastlane/metadata/android/en-US/images/icon.png (In that js script? Copy or symlink?)
  • Automate syncing extraImages/Feature graphic - Google Play.png to fastlane/metadata/android/en-US/images/featureGraphic.png
  • Automate syncing extraImages/Screenshots to fastlane/metadata/android/en-US/images/phoneScreenshots
  • Place hooks into template.properties to ask for translations for the full_description.txt and short_description.txt files
  • Automate copying these translations into the fastlane structure (In TranslationFileWriter?)

P.S.: I snuck in an updated "MapEditor" phone image. I opted for an Europe map and the View tab.

@JackRainy
Copy link
Collaborator

It seems the content of full_description.txt in de and en-US are swapped.

@SomeTroglodyte
Copy link
Collaborator Author

Not only swapped, Notpadqq somehow used an encoding Studio didn't like, so I let it choose.

@yairm210
Copy link
Owner

I separated this logic into a separate fine precisely so it could be run with node locally :)

Copy link
Collaborator

@xlenstra xlenstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it intentional that the en-US/full_description.txt is now empty, while the same file for de/ does contain the full description?

@SomeTroglodyte
Copy link
Collaborator Author

separate fine

fine as in pay money for some transgression?

now empty

What??? I had them open side by side and AS in such a case even cleverly prepends enough path to distinguish them - should be impossible to fumble...

@xlenstra xlenstra merged commit 1bb0643 into yairm210:master Apr 26, 2022
@SomeTroglodyte SomeTroglodyte deleted the Fastlane branch April 26, 2022 17:46
@SomeTroglodyte
Copy link
Collaborator Author

SomeTroglodyte commented Apr 28, 2022

The PR for the first to-do item is here - a major PITA to create that on gitlab. The direct edit persistently refuses any changes "someone else was faster than you" (impossible to be always the case), and the web IDE takes up to 5 minutes for each and every tiny step.... I have no idea how to deal with that "fast-forward merge is not possible", though. Rollback - too many unrelated mails from their gitlab bot. Update: Our friend linsui did it just now.

ultradian pushed a commit to ultradian/Unciv that referenced this pull request May 2, 2022
* Implement fastlane step 1 - minimal framework

* Implement fastlane step 1 - fix en/de swap, encoding and a typo

* Implement fastlane step 1 - fix en-US description empty
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Icon is missing on F-Droid.
4 participants