Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recycling center #5738

Merged
merged 13 commits into from
Dec 3, 2021
Merged

Recycling center #5738

merged 13 commits into from
Dec 3, 2021

Conversation

itanasi
Copy link
Contributor

@itanasi itanasi commented Dec 2, 2021

Adds Recycling Center
Blocks showing the building in the choices if 5 or more are built
If 5 are building, still shows but with a Rejection Text
Image included thanks to @SimonCeder. Credit added to Credits.md

temurakami added 11 commits November 21, 2021 23:22
Add Recycling Center entry to JSON
Need Graphical Icon
Add TODO
Rephrase Rejection text
Updated .atlas and .png
Add code to block showing Recycling Center
Set shouldShow to True so iot still appears while under construction but not completed
Remove debug prints
temurakami added 2 commits December 2, 2021 20:19
Reword text. Unique can apply to Buildings and Units
Refactor Signature since not just Buildings
@itanasi
Copy link
Contributor Author

itanasi commented Dec 3, 2021

Resolved requests. Added code to destroy building if exceeds max allowed (including enqueued). Tested in Human v Human game both captured and traded.

Future improvement: perhaps remove (and refund) queued buildings first before resorting to destroying the new one in the captured/traded city. But that's a bit complicated for today's work

@yairm210 yairm210 merged commit 7f07bcb into yairm210:master Dec 3, 2021
@itanasi itanasi deleted the recycling_center branch January 16, 2022 04:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants