-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Recycling center #5738
Merged
Merged
Recycling center #5738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add Recycling Center entry to JSON Need Graphical Icon
Rephrase Rejection text Updated .atlas and .png Add code to block showing Recycling Center
# Conflicts: # docs/uniques.md
Set shouldShow to True so iot still appears while under construction but not completed
Remove debug prints
yairm210
reviewed
Dec 2, 2021
yairm210
reviewed
Dec 2, 2021
Reword text. Unique can apply to Buildings and Units Refactor Signature since not just Buildings
Resolved requests. Added code to destroy building if exceeds max allowed (including enqueued). Tested in Human v Human game both captured and traded. Future improvement: perhaps remove (and refund) queued buildings first before resorting to destroying the new one in the captured/traded city. But that's a bit complicated for today's work |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds Recycling Center
Blocks showing the building in the choices if 5 or more are built
If 5 are building, still shows but with a Rejection Text
Image included thanks to @SimonCeder. Credit added to Credits.md