Make Guided Missile Free (and Maintenance overhaul) #5698
Conversation
|
Wait, put on hold. Didn't add translation entries |
|
No template necessary, the json will be picked up. But don't include unrelated build script changes. You may get wrong results though as far as I can guess - they can be counted twice since they can also count as garrisoned? I'll leave looking more thoroughly to you. |
Add UnitMaintenanceDiscount Rename UnitMaintenanceDiscount->UnitMaintenanceDiscountGlobal Rework maintenance equation to account for overlapping reductions Add maintenance variable to MapUnit
|
New version built. |
itanasi
changed the title
| // Note all discounts are in the form of -X%, such as -25 for 25% reduction | ||
| for (unit in unitsToPayFor){ | ||
| if (unit.hasUnique(UniqueType.UnitMaintenanceDiscount)){ | ||
| unit.maintenance = 1f + unit.getMatchingUniques(UniqueType.UnitMaintenanceDiscount).first().params[0].toFloat()/100f |
There was a problem hiding this comment.
Use unique.param[0].toPercent()
| // Apply global discounts | ||
| for (unique in civInfo.getMatchingUniques(UniqueType.UnitMaintenanceDiscountGlobal, StateForConditionals(civInfo))) { | ||
| for (unit in unitsToPayFor.filter{it.matchesFilter(unique.params[1])}){ | ||
| unit.maintenance *= 1f + unique.params[0].toFloat()/100f |
| unitsToPayFor = unitsToPayFor.sortedByDescending { it.maintenance }.drop(freeUnits) | ||
| val numberOfUnitsToPayFor = max(0.0, unitsToPayFor.sumOf { it.maintenance.toDouble() }).toFloat() | ||
|
|
||
| // var numberOfUnitsToPayFor = max(0f, unitsToPayFor.count().toFloat() - freeUnits) |
| @@ -1474,6 +1474,7 @@ | |||
| "range": 8, | |||
| "cost": 150, | |||
| "requiredTech": "Advanced Ballistics", | |||
| "uniques": ["-100% maintenance costs"], | |||
There was a problem hiding this comment.
Number needs to be in square brackets
More robust uniques check code so not assuming only one matching unique Use toPercent()
|
Thanks for the comments. Code cleaned up and this time validated against actual commit |
Adds support for NoMaintenance
Applies feature to Guided Missile
Change listed in #4697