-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modmanager sort and filter #5186
Conversation
- MM switches to stacked expanders in portrait. - Use AutoScrollPanes. - Disable the enter/leave listener of AutoScrollPane in Pickers which disable the default ScrollPane to roll their own - helps all such pickers. - No expander open/close persistence on purpose. - PickerScreen a bit cleaned 'cuz I needed to understand something. - Marked mods from the kill-list that are already installed. - Button sync now OK when counterpart missing (deselects other column).
# Conflicts: # core/src/com/unciv/ui/worldscreen/mainmenu/OptionsPopup.kt
Oh my gosh |
Nah. The biggest improvement / most minutes spent on is actually that a resize or orientation switch does not forget the queried stuff, it just stops a running query. Makes you also hit the rate limit a bit less, rare anyway. You can see the filter by simply re-opening the expander, I had hoped that might be enough, and our users should have a brain with short-term memory, too - hopefully. I'll mull it over for an hour or three. |
Actually, I'd prefer to leave this as is for now. Too many ideas on how to clarify and - works better than nothing. The ideas to clarify a filter is in effect I could currently list are:
I repeat: To see what you're filtering by with this version, just hit enter - it's a toggle for the expander. Maybe await user feedback before deciding on a how-to-clarify-current-filter? |
A little monster to close #5118
video
Peek.2021-09-11.Mod.Sort.mp4
Forgot tooltip(s) and to focus the search box on any sort-expander open, not only when opening it using the enter key... Maybe later.