Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modmanager sort and filter #5186

Merged
merged 10 commits into from
Sep 16, 2021
Merged

Conversation

SomeTroglodyte
Copy link
Collaborator

A little monster to close #5118

video
Peek.2021-09-11.Mod.Sort.mp4

Forgot tooltip(s) and to focus the search box on any sort-expander open, not only when opening it using the enter key... Maybe later.

- MM switches to stacked expanders in portrait.
- Use AutoScrollPanes.
- Disable the enter/leave listener of AutoScrollPane in Pickers which disable the default ScrollPane to roll their own - helps all such pickers.
- No expander open/close persistence on purpose.
- PickerScreen a bit cleaned 'cuz I needed to understand something.
- Marked mods from the kill-list that are already installed.
- Button sync now OK when counterpart missing (deselects other column).
# Conflicts:
#	core/src/com/unciv/ui/worldscreen/mainmenu/OptionsPopup.kt
@yairm210
Copy link
Owner

Oh my gosh
This is a hell of a thing to submit all in one sitting
The only "complaint" I have is that if you filter by text, and you close the filter, you can't see what you're filtering by.
Unlike the sorting, where you can always see the sort status.

@SomeTroglodyte
Copy link
Collaborator Author

hell of a thing

Nah. The biggest improvement / most minutes spent on is actually that a resize or orientation switch does not forget the queried stuff, it just stops a running query. Makes you also hit the rate limit a bit less, rare anyway.

You can see the filter by simply re-opening the expander, I had hoped that might be enough, and our users should have a brain with short-term memory, too - hopefully. I'll mull it over for an hour or three.

@SomeTroglodyte
Copy link
Collaborator Author

Actually, I'd prefer to leave this as is for now. Too many ideas on how to clarify and - works better than nothing.

The ideas to clarify a filter is in effect I could currently list are:

  • Block closing the expander while a filter applies (and offer a quicker clear filter)
  • Mark within the expander header - classic office icon - what's "Entonnoir" in english? Funnel. Problem: Funnel icons are dégeulasse (ugly).
  • Add the filter indicator to the column headers explicitly as (filtered)

I repeat: To see what you're filtering by with this version, just hit enter - it's a toggle for the expander.

Maybe await user feedback before deciding on a how-to-clarify-current-filter?

@yairm210 yairm210 merged commit 5fd04f6 into yairm210:master Sep 16, 2021
@SomeTroglodyte SomeTroglodyte deleted the Modmanager-sort branch September 16, 2021 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Suggestion: Update button, Mod search and Mod Sort
2 participants