Implement production overflow #4081
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As discussed on yairm210#4058, production (or hammer) overflow in Civ 5 is a thing and goes according to rules described on https://forums.civfanatics.com/threads/hammer-overflow.419352/ This has been added to the game. There are no visual indicators for the user yet. This will probably be added later.
|
Clean, simple, and elegant |
|
Fields not present are given the default value - in this case, 0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed on #4058, production (or hammer) overflow in Civ 5 is a thing and goes according to rules described on https://forums.civfanatics.com/threads/hammer-overflow.419352/ . This has been added to the game.
Currently there are no visual indicators that there is an overflow present. I don't know if and where these should be added. I think (but don't know) Civ 5 doesn't communicate this in any way either so maybe it is good as is. Suggestions are welcome.
I also don't know how an older version would react to a new game with the field
productionOverflow. In general, how do older versions react to units/data fields they don't think should exist?