Spruced up ModManagementScreen - phase 1 #3983
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the trimmed down version of - and will resolve #3912 (even if you don't like this we'll close that one). Merging bits into a fresh branch was hopeless, diff matched and grouped too wildly off, both AS and Meld. So I took the other way round and trimmed away - which must serve as an excuse for the fact this is still quite voluminous.
Features
Bugfixes
(both effects aren't so rare - one or the other hits at least 33% of the time in my experience, way too much for the offered explanations, but I can't come up with better ones)
Maybe-bugfixes
Unsuccessfully tried
Could we check whether an author has updated its images but forgotten to repack his atlas or push it? My investigations showed - none of the file operations kept lastModified, which doesn't matter because a GitHub zip contains timestamps that have notching to do with the age of the contained files - it generates a fresh zip every time setting all timestamps to the request time. So, a check for atlas validity would involve several GitHub api calls - sorry I stopped there.
Features Removed for this step
And a few instances of linting - some you might not like, I probably didn't myself, but sometimes it's easier to accept an elvis operator than silencing Android Studio in other ways. As always, criticism welcome.
This did a few rounds of testing, most desktop, but also including an Oreo AVD and my Pie-level physical tablet.