Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor update on Credits.md #1949

Merged
merged 1 commit into from
Feb 16, 2020
Merged

Minor update on Credits.md #1949

merged 1 commit into from
Feb 16, 2020

Conversation

u-ndefine
Copy link
Contributor

Nations

  • Fix typo on word "crescent"
  • Fix link that flew off on word "sword"

# Nations
- Fix typo on word "crescent"
- Fix link that flew off on word "sword"
@yairm210 yairm210 merged commit 609c8f8 into yairm210:master Feb 16, 2020
yairm210 added a commit that referenced this pull request Feb 17, 2020
* Added Multiplayer Turn Notification Service
#1680

* Minor update on Credits.md (#1949)

# Nations
- Fix typo on word "crescent"
- Fix link that flew off on word "sword"

* 3.5.14-patch1

* Edit startgame screen. (#1950)

Co-authored-by: u-ndefine <41176671+u-ndefine@users.noreply.github.com>

* Small improvements suggested in pull request review
#1947

* Removed potential concurrency hazzards caused by access to non-final variables. Added option to turn off persistent notification (may be necessary on pre-Oreo phones.)
Added suggested comments. #1947

* Fixed miscommited debug code. #1947

Co-authored-by: u-ndefine <41176671+u-ndefine@users.noreply.github.com>
Co-authored-by: Yair Morgenstern <yairm210@hotmail.com>
Co-authored-by: lishaoxia1985 <49801619+lishaoxia1985@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants