Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor Fix to Cleanup Console #4

Closed
wants to merge 1 commit into from

Conversation

mdashti
Copy link

@mdashti mdashti commented Feb 9, 2021

If you use dragsort with Tagify and then you double click on a tag to modify it and then drag the tag in edit mode, you'll see the following error in console:

Uncaught TypeError: t.closest is not a function
    getDraggableElm file:///chart/assets/js/dragsort.js:1
    dragenter file:///chart/assets/js/dragsort.js:1
    dragenter file:///chart/assets/js/dragsort.js:1
    bindEvents file:///chart/assets/js/dragsort.js:1
    n file:///chart/assets/js/dragsort.js:1
    DragSort file:///chart/assets/js/dragsort.js:1
    <anonymous> file:///chart/index.html#branches[]=master:701
    onload file:///chart/index.html#branches[]=master:1089
    getGZipJSON file:///chart/index.html#branches[]=master:1079
    <anonymous> file:///chart/index.html#branches[]=master:681
    onload file:///chart/index.html#branches[]=master:1089
    getGZipJSON file:///chart/index.html#branches[]=master:1079
    <anonymous> file:///chart/index.html#branches[]=master:622
    jQuery 13
dragsort.js:1:879

This fix prevents unnecessary errors in the console.

@yairEO
Copy link
Owner

yairEO commented Feb 9, 2021

Thanks, good catch, I will change a bit and push the fix

@yairEO yairEO closed this in 7188fea Feb 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants