Skip to content

Building bin/qbg is happening even with NGT_QBG_DISABLED #157

Closed
@lerouxrgd

Description

@lerouxrgd

Hello,

I noticed that even though I set NGT_QBG_DISABLED=ON CMake will build bin/qbg due to:

add_subdirectory("${PROJECT_SOURCE_DIR}/bin/qbg")

This actually prevents ngt-rs from building without QBG (testing with cargo test) when using NGT 2.2.1.
You can actually test it locally on this branch.

I guess the cause is the following if statement:

	if(NOT DEFINED NGT_SHARED_MEMORY_ALLOCATOR OR (NOT ${NGT_SHARED_MEMORY_ALLOCATOR}))
		add_subdirectory("${PROJECT_SOURCE_DIR}/bin/qbg")
        endif()

Would it be possible to check NGT_QBG_DISABLED instead of NGT_SHARED_MEMORY_ALLOCATOR in this if statement ?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions