Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replay processing ungracefully aborts if a transaction node is not a sequence #289

Closed
bneradt opened this issue Oct 17, 2023 · 0 comments · Fixed by #290
Closed

Replay processing ungracefully aborts if a transaction node is not a sequence #289

bneradt opened this issue Oct 17, 2023 · 0 comments · Fixed by #290
Assignees
@bneradt
Labels
bug Something isn't working

Comments

@bneradt
Copy link
Collaborator

bneradt commented Oct 17, 2023

@Rwardc observed in #288 that if a replay file is passed a non-sequence node to transactions, Proxy Verifier aborts with an uncaught exception. We should handle this more gracefully.
@bneradt bneradt added the bug Something isn't working label Oct 17, 2023
@bneradt bneradt self-assigned this Oct 17, 2023
bneradt added a commit to bneradt/proxy-verifier that referenced this issue Oct 17, 2023
@bneradt
Gracefully handle non-sequence transactions
781c814 
We should stop processing a transaction list if the element is not a
sequence. This will propagate an error rather than aborting with an
uncaught exception later.

Fixes yahoo#289
@bneradt bneradt mentioned this issue Oct 17, 2023
Merged
bneradt added a commit that referenced this issue Oct 17, 2023
@bneradt
Gracefully handle non-sequence transactions (#290)
9d5a4fd 
We should stop processing a transaction list if the element is not a
sequence. This will propagate an error rather than aborting with an
uncaught exception later.

Fixes #289
@bneradt bneradt mentioned this issue Oct 17, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bneradt bneradt

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Gracefully handle non-sequence transactions bneradt/proxy-verifier
1 participant
@bneradt