Skip to content

Simplify metrics registration #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 23, 2024
Merged

Simplify metrics registration #2

merged 2 commits into from
Oct 23, 2024

Conversation

StephenButtolph
Copy link

Why this should be merged

Rather than passing around callbacks, I think we can just move where registration takes place.

How this works

  1. getOrMakeVMRegisterer -> getOrMakeVMGatherer
  2. makeAndRegister -> gone

How this was tested

N/A

@yacovm yacovm merged commit 7d0aeee into yacovm:cleanup_metrics2 Oct 23, 2024
@yacovm yacovm deleted the cleanup_metrics3 branch October 23, 2024 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yacovm yacovm yacovm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@StephenButtolph @yacovm