Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bug #1068 #1097

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix bug #1068 #1097

wants to merge 1 commit into from

Conversation

vovatolstousov
Copy link

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
New tests added? not yet
Fixed tickets #1068
License MIT

Description

[Bug fixed]

Please, don't submit /dist files with your PR!

@coveralls
Copy link

Coverage Status

Coverage remained the same at 94.844% when pulling 2a5b77f on vovatolstousov:master into 0820080 on yabwe:master.

@rishijain
Copy link
Contributor

rishijain commented May 24, 2016

Hi @vovatolstousov , can you remove the dist files from the commit and make your changes in appropriate file under in src/js.

@j0k3r
Copy link
Contributor

j0k3r commented May 24, 2016

Also, could you try to add some tests so that before your change the test is failing and after applying your change the test is green?

@Olgagr
Copy link
Contributor

Olgagr commented May 27, 2016

@vovatolstousov I think this not resolve the problem. The problem is that when a list is removed, the content of the list becomes text node, not block element (in this case it should be paragraph).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants