Core: Add Javadoc for LoadTableResponse, fix error prone warnings (ap…

…ache#5053)

core/src/main/java/org/apache/iceberg/rest/requests/RenameTableRequest.java

@@ -43,6 +43,7 @@ private RenameTableRequest(TableIdentifier source, TableIdentifier destination)
     validate();
   }
 
+  @Override
   public void validate() {
     Preconditions.checkArgument(source != null, "Invalid source table: null");
     Preconditions.checkArgument(destination != null, "Invalid destination table: null");

core/src/main/java/org/apache/iceberg/rest/responses/LoadTableResponse.java

@@ -28,7 +28,12 @@
 import org.apache.iceberg.rest.RESTResponse;
 
 /**
- *
+ * A REST response that is used when a table is successfully loaded.
+ * <p>
+ * This class is used whenever the response to a request is a table's requested metadata and the associated location
+ * of its metadata, to reduce code duplication. This includes using this class as the response for
+ * {@link org.apache.iceberg.rest.requests.CreateTableRequest}, including when that request is used to commit
+ * an already staged table creation as part of a transaction.
  */
 public class LoadTableResponse implements RESTResponse {
 

core/src/main/java/org/apache/iceberg/rest/responses/OAuthTokenResponse.java

@@ -80,6 +80,9 @@ public static class Builder {
     private Integer expiresInSeconds;
     private final List<String> scopes = Lists.newArrayList();
 
+    private Builder() {
+    }
+
     public Builder withToken(String token) {
       this.accessToken = token;
       return this;