handle close failures

yaananth · Mar 28, 2022 · 0eb4ee2 · 0eb4ee2
1 parent b3b97b7
commit 0eb4ee2
Showing 1 changed file with 11 additions and 1 deletion.
diff --git a/src/Runner.Common/JobServer.cs b/src/Runner.Common/JobServer.cs
@@ -143,8 +143,18 @@ public void InitializeWebsocketClient(ServiceEndpoint serviceEndpoint)
 
         public ValueTask DisposeAsync()
         {
-            _websocketClient?.CloseOutputAsync(WebSocketCloseStatus.NormalClosure, "Shutdown", CancellationToken.None);
+            try
+            {
+                _websocketClient?.CloseOutputAsync(WebSocketCloseStatus.NormalClosure, "Shutdown", CancellationToken.None);
+            }
+            catch (Exception ex)
+            {
+                // In some cases this might be okay since the websocket might be open yet, so just close and don't trace exceptions
+                Trace.Info($"Failed to close websocket gracefully {ex.GetType().Name}");
+            }
+
             GC.SuppressFinalize(this);
+
             return ValueTask.CompletedTask;
         }