-
Notifications
You must be signed in to change notification settings - Fork 81
refactor(core-clp): Replace clp::error_handling
with ystdlib::error_handling
.
#772
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(core-clp): Replace clp::error_handling
with ystdlib::error_handling
.
#772
Conversation
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
WalkthroughThis pull request removes the custom error handling header and its associated unit tests from the core component while updating error code handling to use the new Changes
Suggested reviewers
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (11)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
clp::error_handling
module and migrate all usages ystdlib::error_handling
.
clp::error_handling
module and migrate all usages ystdlib::error_handling
.clp::error_handling
and its unit tests; fix all reference sites to use ystdlib::error_handling
.
clp::error_handling
and its unit tests; fix all reference sites to use ystdlib::error_handling
.clp::error_handling
and its unit tests; fix all reference sites to use ystdlib::error_handling
.
Co-authored-by: davidlion <davidlion2@protonmail.com>
clp::error_handling
and its unit tests; fix all reference sites to use ystdlib::error_handling
.clp::error_handling
with ystdlib::error_handling
.
Description
Change
clp::ffi::IrErrorCode
to depend onystdlib::error_handling::ErrorCode
.This PR follows the addition of
ystdlib-cpp
#730This PR contributes to #764
Checklist
breaking change.
Validation performed
clp::ffi::IrErrorCode
still pass.Summary by CodeRabbit
These changes enhance the robustness and clarity of error management, ensuring a more reliable experience for end-users without altering visible functionality.