-
Notifications
You must be signed in to change notification settings - Fork 81
feat(log-viewer-webui): Add support for loading IR/JSON streams from S3. #673
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
51 commits
Select commit
Hold shift + click to select a range
28b597f
Initial backup
haiqi96 75e32ea
Adding
haiqi96 a08c558
Adding binary side support
haiqi96 dda24c5
Fix for binary support
haiqi96 722430c
Support s3 uploading for extraction task
haiqi96 3624586
C++ linter
haiqi96 85a832b
python linter
haiqi96 b970950
Use some subclass trick
haiqi96 0d34484
Merge branch 'main' into jsonl_upload
haiqi96 fdf8de3
Linter and other rearrangements
haiqi96 f933099
Merge branch 'main' into jsonl_upload
haiqi96 e506044
Remove unnecessary print
haiqi96 5aac350
Missing changes
haiqi96 5735449
Initial working version
haiqi96 bb5f9cc
simple renaming
haiqi96 2e47b72
Rename arguments for now
haiqi96 7481d53
Add default value
haiqi96 285384c
Address code review comments.
haiqi96 856664f
Apply suggestions from code review
haiqi96 473a613
Merge branch 'main' into jsonl_upload
haiqi96 7340c71
Update to work with latest codebase
haiqi96 9b09987
Merge branch 'jsonl_upload' into webui_s3_chunks
haiqi96 c6a1ad2
Update config (it's so small so I don't bother to make it a separate PR)
haiqi96 8a295df
Merge branch 'jsonl_upload' into webui_s3_chunks
haiqi96 ff14a5b
Linter
haiqi96 429b976
Merge branch 'jsonl_upload' into webui_s3_chunks
haiqi96 ef7fd82
Use environmental variable to handle S3 credentials for log viewer webui
haiqi96 518eec9
Attempt to fix linter
haiqi96 b2c842b
Merge branch 'main' into jsonl_upload
haiqi96 05bf3f6
Apply suggestions from code review
haiqi96 b6c8e69
Resolve simpler comments
haiqi96 db47554
Combine argument checking
haiqi96 4098ee5
fix stupid mistake
haiqi96 04b94ba
Add CLP prefix to env
haiqi96 b1827d1
Merge branch 'jsonl_upload' into webui_s3_chunks
haiqi96 abaabd8
Address review comment
haiqi96 2da0c15
Apply suggestions from code review
haiqi96 3ba8b89
Merge branch 'webui_s3_chunks' of https://github.com/haiqi96/clp_fork…
haiqi96 cf6a6c1
Update AWS sdk version
haiqi96 812de08
Use constant as requested in code review
haiqi96 59751c0
Linter
haiqi96 f37f40e
Merge branch 'main' into webui_s3_chunks
haiqi96 8e47f61
Add error check for S3 URL generation
haiqi96 a537b73
Use Null for optional values
haiqi96 78625a3
Linter
haiqi96 e8560d4
Apply suggestions from code review
haiqi96 33a7f8b
Address comments
haiqi96 dca12aa
update api versions
haiqi96 49fa164
fix docstrings
haiqi96 3a31483
Update components/log-viewer-webui/server/settings.json
kirkrodrigues 1476f7b
Apply suggestions from code review
kirkrodrigues File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.