-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(log-viewer-webui): Migrate server codebase to TypeScript and update dependencies. #647
Open
junhaoliao
wants to merge
8
commits into
y-scope:main
Choose a base branch
from
junhaoliao:log-viewer-webui-server-ts
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+3,358
−3,670
Open
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
89dfb45
chore(log-viewer-webui): Migrate server codebase to TypeScript and up…
junhaoliao 1f50cb1
Add more TS checks.
junhaoliao 85e6ff2
Fix lint.
junhaoliao 13192bd
Fix lint.
junhaoliao 58a434c
Replace arrays with sets for faster lookup.
junhaoliao a11b15b
Update package.json to use npm ci for deterministic installs.
junhaoliao ef0aca7
Update eslint-config-yscope to 1.0.0 and move config into eslint.conf…
junhaoliao 49f7115
Update dependencies.
junhaoliao File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Fix lint.
- Loading branch information
commit 85e6ff23f141241121154a86f57136f48fccd162
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Compared to the original
main.js
, changes in this file include:envToLogger
was pulled out from themain()
scope into global scope.process.env.NODE_ENV
was removed in favour ofparseEnv().NODE_ENV
, which requiresparseEnv()
to also parseNODE_ENV
from the environment variables.isKnownNodeEnv()
for easier type deduction.