Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ffi: Add support for serializing/deserializing auto-generated and user-generated schema tree node IDs. #557
ffi: Add support for serializing/deserializing auto-generated and user-generated schema tree node IDs. #557
Changes from 6 commits
e0249ab
eda7c4a
14706b3
328e9c9
3981538
fcbd496
0f7616f
c1cbb87
ae86bfe
eb5e9ea
dc5d0b5
26a43ca
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I didn't notice this in the doc but I did notice it now---why are we adding support for 4-byte node IDs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we change the way of how node IDs are encoded, the range of node IDs supported also changed (dropped from max=65535 to max=32767). The 4-byte node ID tags are already reserved in the protocol, we just didn't implement them in our first iteration. Adding it with this PR in case 32767 isn't enough to cover all schema tree nodes. I thought Devin had same concern before and he mentioned maybe we should add support for 4-byte ID encodings. However, with the auto-generated IDs supported, arguably we could shift some kv pairs to the auto-generated namespace, so maybe 32767 should be a reasonably large space...