clp-s: Handle cases where clp-string query-parsing falls back to decompress + match (fixes #403). #407
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kirkrodrigues
requested changes
May 31, 2024
| #include "../ArchiveReader.hpp" | ||
| #include "../FileWriter.hpp" | ||
| #include "../ReaderUtils.hpp" | ||
| #include "../Utils.hpp" |
There was a problem hiding this comment.
I think StringUtils still needs this as a direct include.
| // don't't add more wildcards. Likewise if it already contains some wildcards | ||
| // we do not add more | ||
| Grep::process_raw_query( | ||
| m_string_query_map[query_string] = std::move(Grep::process_raw_query( |
There was a problem hiding this comment.
Shall we switch to emplace instead?
kirkrodrigues
previously approved these changes
Jun 3, 2024
There was a problem hiding this comment.
One small suggestion.
For the PR title, how about:
clp-s: Handle cases where clp-string query-parsing falls back to decompress + match (fixes #403).
| bool is_var; | ||
| // FIXME: may want to use non-heuristic method of tokenizing query | ||
| // if (use_heuristic) { | ||
|
|
wraymo
changed the title
kirkrodrigues
approved these changes
Jun 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
#403
Description
Previously, when a query did not contain a subquery, it was not evaluated in clp-s. However, in cases where
matchability = SubQueryMatchabilityResult::SupercedesAllSubQueries, this caused an issue. This PR fixes the bug, which indirectly resolves issue #403. The primary code change aligns clp-s with the behavior of clp inGrep::process_raw_query. The relevant code inclp_s/search/Output.cpphas also been updated.Validation performed