Add support for tagging archives and filtering by tags. #285
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kirkrodrigues
requested changes
Feb 21, 2024
components/clp-package-utils/clp_package_utils/scripts/compress.py
Outdated
Show resolved
Hide resolved
components/clp-package-utils/clp_package_utils/scripts/native/compress.py
Outdated
Show resolved
Hide resolved
components/clp-package-utils/clp_package_utils/scripts/native/compress.py
Outdated
Show resolved
Hide resolved
components/clp-package-utils/clp_package_utils/scripts/search.py
Outdated
Show resolved
Hide resolved
components/clp-package-utils/clp_package_utils/scripts/search.py
Outdated
Show resolved
Hide resolved
components/clp-package-utils/clp_package_utils/scripts/native/search.py
Outdated
Show resolved
Hide resolved
components/clp-package-utils/clp_package_utils/scripts/native/search.py
Outdated
Show resolved
Hide resolved
components/job-orchestration/job_orchestration/scheduler/search/search_scheduler.py
Show resolved
Hide resolved
components/job-orchestration/job_orchestration/scheduler/search/search_scheduler.py
Outdated
Show resolved
Hide resolved
components/job-orchestration/job_orchestration/executor/compress/fs_compression_task.py
Outdated
Show resolved
Hide resolved
Yeah, i think we should restrict the tags to not containing whitespace. |
kirkrodrigues
requested changes
Feb 22, 2024
components/job-orchestration/job_orchestration/executor/compress/fs_compression_task.py
Outdated
Show resolved
Hide resolved
components/job-orchestration/job_orchestration/scheduler/job_config.py
Outdated
Show resolved
Hide resolved
components/job-orchestration/job_orchestration/scheduler/search/search_scheduler.py
Outdated
Show resolved
Hide resolved
components/clp-package-utils/clp_package_utils/scripts/compress.py
Outdated
Show resolved
Hide resolved
components/clp-package-utils/clp_package_utils/scripts/native/compress.py
Outdated
Show resolved
Hide resolved
kirkrodrigues
requested changes
Feb 23, 2024
components/job-orchestration/job_orchestration/scheduler/compress/compression_scheduler.py
Outdated
Show resolved
Hide resolved
kirkrodrigues
approved these changes
Feb 27, 2024
wraymo
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Description
This PR introduces the ability to specify tags while compressing files. The resulting compressed archive can now include zero to multiple tags. Users can filter archives during searches using tags.
Validation performed
tag1andtag2.org.apache.hadoop.metrics2.impl.MetricsConfig: loaded properties from hadoop-metrics2.propertiesin three ways. 1) withtag1, 2) withtag23) without tags. Results showed 1) and 2) returned equal amount of logs while 3) returned twice the amount of logs.tag1andtag2.id: 22419in three ways. 1) withtag1, 2) withtag23) without tags. Results showed 1) and 2) returned equal amount of logs while 3) returned twice the amount of logs.