-
Notifications
You must be signed in to change notification settings - Fork 82
Add new compression scheduler implementation for improved simplicity and robustness; Remove old scheduler and consolidate the new schedulers #238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
c4f9bff
to
3bfbe75
Compare
components/clp-package-utils/clp_package_utils/scripts/native/compress.py
Outdated
Show resolved
Hide resolved
components/job-orchestration/job_orchestration/executor/search/celeryconfig.py
Show resolved
Hide resolved
components/job-orchestration/job_orchestration/scheduler/compress/compression_scheduler.py
Outdated
Show resolved
Hide resolved
components/job-orchestration/job_orchestration/scheduler/compress/compression_scheduler.py
Show resolved
Hide resolved
components/job-orchestration/job_orchestration/scheduler/scheduler_data.py
Outdated
Show resolved
Hide resolved
components/job-orchestration/job_orchestration/scheduler/scheduler_data.py
Outdated
Show resolved
Hide resolved
components/job-orchestration/job_orchestration/scheduler/scheduler_data.py
Outdated
Show resolved
Hide resolved
components/clp-package-utils/clp_package_utils/scripts/native/compress.py
Outdated
Show resolved
Hide resolved
components/job-orchestration/job_orchestration/scheduler/compress/partition.py
Outdated
Show resolved
Hide resolved
components/job-orchestration/job_orchestration/scheduler/compress/partition.py
Outdated
Show resolved
Hide resolved
components/job-orchestration/job_orchestration/scheduler/compress/compression_scheduler.py
Outdated
Show resolved
Hide resolved
components/job-orchestration/job_orchestration/scheduler/compress/compression_scheduler.py
Outdated
Show resolved
Hide resolved
jobs = fetch_new_jobs(db_cursor) | ||
db_conn.commit() | ||
for job_row in jobs: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we move db_conn.commit()
into fetch_new_jobs
(to keep it modular if we ever use the function elsewhere) and then we can simplify the loop to:
jobs = fetch_new_jobs(db_cursor) | |
db_conn.commit() | |
for job_row in jobs: | |
for job_row in fetch_new_jobs(db_conn, db_cursor): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But we need to pass db_conn
to fetch_new_jobs
while other database functions don't require this parameter and all of them commit outside the function
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fair enough. I think the database ops need some refactoring to be less error prone but we can do that in another PR.
components/job-orchestration/job_orchestration/scheduler/compress/compression_scheduler.py
Outdated
Show resolved
Hide resolved
components/job-orchestration/job_orchestration/scheduler/compress/compression_scheduler.py
Outdated
Show resolved
Hide resolved
components/job-orchestration/job_orchestration/scheduler/compress/compression_scheduler.py
Outdated
Show resolved
Hide resolved
components/job-orchestration/job_orchestration/scheduler/compress/compression_scheduler.py
Outdated
Show resolved
Hide resolved
Commit message: |
Sure, but let me resolve conflicts first |
8c32e2b
to
c4df646
Compare
References
Description
This PR refactors the schedulers by
Validation performed
"org.apache.hadoop.metrics2.impl.MetricsConfig: loaded properties from hadoop-metrics2.properties"