Only search archives within the search time range; Add begin and end timestamp to archive metadata. #138
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kirkrodrigues / @jackluo923 As discussed yesterday can you please review the PR and let us know if you further see any changes in PR or its okay to be merged ? |
|
ref : #139 |
kirkrodrigues
requested changes
Jul 11, 2023
Yadumathur
reviewed
Jul 11, 2023
Yadumathur
reviewed
Jul 11, 2023
Co-authored-by: Yadu Mathur <33775233+Yadumathur@users.noreply.github.com>
kirkrodrigues
requested changes
Jul 11, 2023
…ive metadata in a class; Record segment size after close.
kirkrodrigues
approved these changes
Jul 25, 2023
|
Thanks for your contribution! |
kirkrodrigues
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When using MySQL as metadata db, only retrieve archive directories that have logs in the given search time window. This will improve search performance.
Validation performed
Functional tests on Ubuntu bionic.