Merge latets integrated changes #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d allow it to be re-set even though it's not intended to be used that way.
…on, since temporary variables go out of scope. Instead, manualy divert around. Uglier and more verbose, but more robust.
… EXTERNAL, so we can show an error rather than crashing (in Inky)
… story state, and can be caused before Continue() has been called for the first time
…ibility with Unity (so we can include source)
Clone Element's temporary variables dictionary instead of referencing the same dictionary (leading to variable errors in threads)
Clone Element's temporaryVariables
The previous test :
if (value.GetType () == typeof(T))
return (T) value;
didn't work if "value" type inherited from T
That meant if an external function was supposed to accept any 'object' and was fed with a 'string' it refused it with the error 'Failed to cast String To Object'
Fix casting issue in TryCoerce function
…ect to parse 8,0 for "eight point zero" in France etc)
…ffects which containers get updated with visit counts and turn indices. Exposed ForceEnd() to allow the C# runtime to make this call if necessary.
…ing very random results! Need a better implementation of the actual generation.
…bers, and fix for SEED_RANDOM()
…t "myVar". Slightly confusing :-/
…recent left/right glue pairs are important (therefore I was attempting to cache only the most recent right glue instance), but I was wrong. When you have an empty function, the glues end up getting mismatched, giving the wrong results. This approach requires more glue searching, but hopefully (!) isn't a major performance problem. Added test case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.