Add "bundle mode" option for build system. #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it relatively easy for CMake-based projects to bundle
libdivsufsort instead of creating a hard external dependency. With
this patch, they can simply add_subdirectory(libdivsufsort), and
divsufsort_{LIBRARIES,INCLUDE_DIRS,DEFINITIONS} will be set to the
appropriate values. libdivsufsort will be built as a static library,
and installation will be disabled.
azozes
approved these changes
Apr 13, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it relatively easy for CMake-based projects to bundle libdivsufsort instead of creating a hard external dependency. With this patch, they can simply add_subdirectory(libdivsufsort), and divsufsort_{LIBRARIES,INCLUDE_DIRS,DEFINITIONS} will be set to the appropriate values. libdivsufsort will be built as a static library, and installation will be disabled.
You can see an example of how it can be used at https://github.com/nemequ/bce/tree/bundle-libdivsufsort