DRAFT: Wip binary encode txs #43
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CreatureDev
force-pushed
the
wip-binary-encode-txs
branch
from
6094f30
to
918c80c
Compare
CreatureDev
reviewed
Mar 12, 2024
| type STObject struct { | ||
| OnlySigning bool | ||
| Mutations map[string]FieldMutation | ||
| } | ||
|
|
||
| // FromJson converts a JSON object into a serialized byte slice. | ||
| // It works by converting the JSON object into a map of field instances (which include the field definition | ||
| // and value), and then serializing each field instance. | ||
| // This method returns an error if the JSON input is not a valid object. | ||
| func (t *STObject) FromJson(json any) ([]byte, error) { |
There was a problem hiding this comment.
I did have issues with certain fields, and changed this to use json encoding rather than mapstructure
Needs to add support for ledger object/tx type string as well
You can see my commit here for reference CreatureDev@842ff1f
There was a problem hiding this comment.
relevant PR CreatureDev#4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.