Skip to content

style: xy-theme update #768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 16, 2025
Merged

style: xy-theme update #768

merged 2 commits into from
Apr 16, 2025

Conversation

printerscanner
Copy link
Member

@printerscanner printerscanner commented Apr 14, 2025 •
edited
Loading

Changes

  1. Peter made some changes to theme files in the Svelte update so we don't have to pull the theme file in every time. I pulled this update in and removed the duplicate xy-theme.css files across the examples.
  2. Updated the theme to match changes I will propose in a Pro Apps pull request.
  3. Defining built in variables like button, input broke some things, so I'm suggesting adding a few specific utility variables -> .xy-theme__button, .xy-theme__input, and I've added them to the examples where we have button, input, checkboxes, select and more.
  4. Caught a few bugs in the process

@printerscanner printerscanner requested a review from moklick April 14, 2025 14:38
@vercel Vercel
Copy link

vercel bot commented Apr 14, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
example-apps ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 14, 2025 3:07pm
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
reactflow-website ⬜️ Ignored (Inspect) Visit Preview Apr 14, 2025 3:07pm
svelteflow-website ⬜️ Ignored (Inspect) Visit Preview Apr 14, 2025 3:07pm
ui-components ⬜️ Ignored (Inspect) Visit Preview Apr 14, 2025 3:07pm
xyflow-website ⬜️ Ignored (Inspect) Visit Preview Apr 14, 2025 3:07pm

@printerscanner printerscanner changed the title style: update xy-theme Examples Updates Apr 15, 2025
@printerscanner printerscanner changed the title Examples Updates style: xy-theme update Apr 15, 2025
@printerscanner printerscanner changed the base branch from main to abbey/pro-26-pro-example-overview-page-adjustments April 16, 2025 14:35
@printerscanner printerscanner merged commit 7dda6c7 into abbey/pro-26-pro-example-overview-page-adjustments Apr 16, 2025
6 checks passed
@printerscanner printerscanner deleted the update-xy-theme branch April 16, 2025 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moklick moklick Awaiting requested review from moklick

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@printerscanner